Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Criterion to Divan for benchmarks #113

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Switch from Criterion to Divan for benchmarks #113

merged 2 commits into from
Mar 22, 2024

Conversation

benbrandt
Copy link
Owner

@benbrandt benbrandt commented Mar 22, 2024

Allows for tracking of allocations, not just timing. Since some of the tokenizer implementations can be very costly in terms of allocations, this will make it easier to check the performance improvements if tokenization runs are able to be skipped, both in terms of time, and memory allocation.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.34%. Comparing base (999d567) to head (1e1bc45).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   98.96%   99.34%   +0.37%     
==========================================
  Files           6        6              
  Lines        1452     1374      -78     
==========================================
- Hits         1437     1365      -72     
+ Misses         15        9       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benbrandt benbrandt merged commit 8556955 into main Mar 22, 2024
25 checks passed
@benbrandt benbrandt deleted the divan branch March 22, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant