Fix json target #99
Open
Fix json target #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* build-scripts/gen-ui-info.py: Move imports to the top. (gen_derived, parse_mapfile): Delete procedures. (main): Adjust accordingly.
Automated via Black: $ black -l79 build-scripts/*.py
The avr-gcc cross-compiler should be used as some includes are specific to the AVR target and fail when using a GCC for the host. Also, expose any failure when running the GCC command; previously such errors would only manifest themselves later in a more confusing fashion (see: benblazak#97). Finally, the MAKEFILE_KEYBOARD_LAYOUT macro needs to be specified for the GCC command to succeed. * build-scripts/gen-ui-info.py (gen_mappings.parse_layout_file): Use subprocess.check_output. Replace 'gcc' with 'avr-gcc'. Specify the MAKEFILE_KEYBOARD_LAYOUT macro. Fixes: benblazak#97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.