Skip to content

Commit

Permalink
chore: update to geth 1.14 (alloy-rs#628)
Browse files Browse the repository at this point in the history
  • Loading branch information
DaniPopes authored and ben186 committed Jul 27, 2024
1 parent 3d2edc6 commit 14a8d81
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/scripts/install_test_binaries.sh
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
#!/usr/bin/env bash
# Installs Solc and Geth binaries
# Installs Geth binary
# Note: intended for use only with CI (x86_64 Ubuntu, MacOS or Windows)
set -e

GETH_BUILD=${GETH_BUILD:-"1.13.15-c5ba367e"}
GETH_BUILD=${GETH_BUILD:-"1.14.0-87246f3c"}

BIN_DIR=${BIN_DIR:-"$HOME/bin"}

Expand Down
4 changes: 4 additions & 0 deletions crates/node-bindings/src/geth.rs
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ impl GethInstance {
}

/// Returns the private key used to configure clique on this instance
#[deprecated = "clique support was removed in geth >=1.14"]
pub fn clique_private_key(&self) -> &Option<SigningKey> {
&self.clique_private_key
}
Expand Down Expand Up @@ -301,6 +302,7 @@ impl Geth {
///
/// The address derived from this private key will be used to set the `miner.etherbase` field
/// on the node.
#[deprecated = "clique support was removed in geth >=1.14"]
pub fn set_clique_private_key<T: Into<SigningKey>>(mut self, private_key: T) -> Self {
self.clique_private_key = Some(private_key.into());
self
Expand Down Expand Up @@ -726,6 +728,8 @@ mod tests {
}

#[test]
#[ignore = "fails on geth >=1.14"]
#[allow(deprecated)]
fn clique_correctly_configured() {
run_with_tempdir(|temp_dir_path| {
let private_key = SigningKey::random(&mut rand::thread_rng());
Expand Down

0 comments on commit 14a8d81

Please sign in to comment.