New method for customizing the oracle tree #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben
force-pushed
the
register-oracle-tree
branch
4 times, most recently
from
230c26e to
e85d3d2
Compare
ben
force-pushed
the
register-oracle-tree
branch
from
e85d3d2 to
2844ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed in Discord. This updates the custom-oracle logic to allow a module or hook to register the entire oracle tree on a
readyhook, rather than needing to provide an expensive hook body that runs whenever an oracle window is opened, or an oracle roll is called for.The fundamental change is that the oracle tree node doesn't have an array of async table getters, it has an array of table UUIDs, which is a lot easier to work with, and is easier to get right.
tables: string[]registerOracleTreefunction, which can be called on areadyhook