Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vue config to eslint, and adopt (mostly) standard JS style #682

Merged
merged 9 commits into from
Mar 14, 2023
Merged

Conversation

rsek
Copy link
Collaborator

@rsek rsek commented Mar 14, 2023

i noticed that some v-for directives were missing their keys, so i've added vue's official eslint plugin/config to hint us towards their "best practices".

update: added (mostly) standardjs for prettier and eslint on top of this, and ran autofix for both.

i've diverged on two rules:

  • tabs, which are actual tab characters for accessibility reasons. and so that folks can configure their tab width as desired, instead of forcing it on them
  • explicit return types. it's a sensible rule, but right now the errors are noisy and require a bunch of manual intervention to resolve. i'd be happy to revisist this after i get all my wacky refactors merged.

@rsek rsek changed the title add vue config to eslint add vue config to eslint, and adopt standard JS Mar 14, 2023
@rsek rsek changed the title add vue config to eslint, and adopt standard JS add vue config to eslint, and adopt (mostly) standard JS style Mar 14, 2023
@rsek
Copy link
Collaborator Author

rsek commented Mar 14, 2023

whoops, looks like my local main wasn't up to date when i made this branch. that should now be fixed. it's introduced some CI complains, however -- i'll look at those next.

@rsek rsek mentioned this pull request Mar 14, 2023
6 tasks
@ben
Copy link
Owner

ben commented Mar 14, 2023

Well the tests pass and the system loads, so it's probably okay. Super hard to do a detailed review of something like this. 😁

@ben ben merged commit 4cc5a2c into main Mar 14, 2023
@ben ben deleted the eslint-vue branch March 14, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants