Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor vue render helper into VueApplication base class #639

Merged
merged 22 commits into from
Feb 12, 2023
Merged

Refactor vue render helper into VueApplication base class #639

merged 22 commits into from
Feb 12, 2023

Conversation

ben
Copy link
Owner

@ben ben commented Feb 12, 2023 •
edited
Loading

The separation isn't helping us any more. Let's move the Vue adapter layer into fewer files.

  • Move the render logic into the VueApplication base class
  • Refactor VueActorSheet and VueItemSheet to do the right things
  • Remove the VueRenderHelper file
  • Update and verify all the Vue sheets
    • IS character sheet
    • SF character sheet
    • SF moves/oracles sheet
    • Progress sheet
    • Foe sheet
    • Location sheet
    • Shared sheet
    • Site sheet
    • Starship sheet
    • Oracle window
    • Edit-sector sheet
    • DF-style truths dialog
    • Asset-compendium browser
    • Asset sheet
    • Bondset sheet
    • Move-edit sheet
    • Challenge-dice-resolution dialog
  • Fix those pesky type errors
  • Update CHANGELOG.md

@ben ben marked this pull request as ready for review February 12, 2023 21:22
@ben ben merged commit 3c44927 into main Feb 12, 2023
@ben ben deleted the collapse-vue-helpers branch February 12, 2023 21:58
@ben ben mentioned this pull request Mar 9, 2023
Draft
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ben