-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardized collapsible component #518
Conversation
move jump/highlight links are now working again. now includes an experimental move sheet that pulls in move category colours from dataforged. may only work in FF + light theme + starforged tools at this time -- working out fallbacks and a variation for dark themes comes next, if you think it's worth pursuing. :) this version also goes hogwild with tooltip annotations + icon size to see if it gets annoying. couple additions i'm considering:
|
copying my own discord post so i can find it easily later: snapshot of move sheet progress, which makes move categories collapsible in addition to individual moves. the idea is that in a collapsed state, the theme colour is a big ol' block to add an additional signal of category. but once you get to the level of individual move articles, it being open is readily distinguishable from its siblings. still need to add some strokes to maintain contrast in cases with strange colours, to fix jump links to account to the more nested structure... and to figure out how to convey all that on a dark theme, too, haha also considering adding a flag that maintains open/closed state, since the more layered structure might make it convenient to leave certain categories open. |
to fix before marking ready for review:
stuff i'm thinking about for later PRs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an amazing piece of work. Just one nit and then we can merge it.
Co-authored-by: Ben Straub <[email protected]>
implements a standardized
Collapsible
component with plenty of slots. makesMoveItem
a descendant ofCollapsible
.MoveItem
gets some visual tweaks:i could theoretically apply the same to the move sheet oracle rows -- as well as everything else that collapses -- in this PR, but i'm thinking i'll defer that for the time being and gradually migrate components.
TODO
scrollIntoView
and friendsFor later PRs
Collapsible
features as implementation exposes needs that aren't met yetCollapsibleTree
component fromCollapsible
s (or that simply works as a wrapper)