-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource bar components w/ keyboard controls #501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot, just a few things I noticed. And a reminder that the shared-supply feature got left behind.
<span class="momentum-status-max"> | ||
{{ $t('IRONSWORN.Max') }}: | ||
{{ actor?.data.momentumMax }} | ||
</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe now is when can trim this. We already indicate the max by disabling the high numbers, so this is just left over from the paper sheet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh, yeah, the same thing crossed my mind. we might even take it a step further by marking the reset value with an icon of some kind, and ditching that label, too. it's also conveyed in the burn button tooltip.
@@ -13,6 +13,19 @@ body.theme-starforged { | |||
@text-medium-color: #3dd; | |||
@text-light-color: #6ff; | |||
|
|||
// until this chromium issue with paint-order is resolved, text-stroke is functionally useless: https://bugs.chromium.org/p/chromium/issues/detail?id=815111 | |||
// yes, i am bitter, because even safari has supported it for ~4 years at this point :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌶️ 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting closer, just a few more comments
src/module/vue/components/resource-meter/pc-condition-meters.vue
Outdated
Show resolved
Hide resolved
src/module/vue/components/resource-meter/pc-condition-meters.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben Straub <[email protected]>
Co-authored-by: Ben Straub <[email protected]>
Co-authored-by: Ben Straub <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merge whenever you're ready.
introduces a more unified set of components that are friendly to both Actors and Items.
it also fixes the missing "selected" highlight on the starforged theme (not totally sure when it happened, but a player in one of my co-op games pointed it out).
slider
role;spinbutton
is probably a valid choice here too, TBH, but neither is fully satisfactory. might change my mind again laterreadonly
mode: renders the same slider as a 'readonly' preview, for use in e.g. the asset browser:focus
selector+
signs from resources that don't have negative values (e.g. everything but momentum)ideas for further expansion/refinement:
compact
mode: renders the same slider as a spinner