Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets, Delve, Foes translation #428

Closed
Potatronus opened this issue Aug 12, 2022 · 6 comments
Closed

Assets, Delve, Foes translation #428

Potatronus opened this issue Aug 12, 2022 · 6 comments

Comments

@Potatronus
Copy link

I would like to translate whole ironsworn module Englishglish to polish. Already translated 50% of json in lang/Ibut i don't see the option to translate the assets and the other stuff. Anyone can help me?

@ben
Copy link
Owner

ben commented Aug 12, 2022

The best way to do this would be to make a Babele module which replaces the contents of the built-in compendium items. Target the foundry-ironsworn.ironswornmoves (which will be official soon) and foundry-ironsworn.ironswornassets (official now) compendiums for Ironsworn content.

@ben
Copy link
Owner

ben commented Aug 12, 2022

Oh, and I'd <3 a PR that adds Polish translations. Take a look at #14 to see what kinds of change you'll need to make to system.json.

@Potatronus
Copy link
Author

Potatronus commented Aug 12, 2022

I'm not the IT guy, to be honest, just created this account to work on translation :).
At this moment I'm working with descriptors used in foundry-ironsworn/lang/*.json which work with move descriptors, general descriptors used in-game, delves and some tables.

I also added in system.json
{
lang": "pl",
"name": "Polski",
"path": "lang/pl.json"
}
The data I have in English I can properly translate. At this moment I translated it is still early state. But there is no descriptors for assets in lang/.en.json to translate ;)

image

@ben
Copy link
Owner

ben commented Aug 13, 2022

That's great! Can you post the pl.json file somewhere I can download it, and I'll make a PR to integrate it?

@Potatronus
Copy link
Author

Potatronus commented Aug 18, 2022

That's great! Can you post the pl.json file somewhere I can download it, and I'll make a PR to integrate it?

Hey, sure. I didn't have a chance to finish the full translation yet, but still, I can upload a json. I don't know how to upload it @ github (I tried to use a pull request and add a file AND the code change, but afaik it didn't work), so I will give you a link to drive with pl.json

https://drive.google.com/drive/folders/1ySdbPch5N4E0Eo6ncdN2cwohsT4Ums8y?usp=sharing

Ofc I will update it soon and give you a sing when the full first draft will be ready.

ben added a commit that referenced this issue Aug 20, 2022
@ben
Copy link
Owner

ben commented Aug 20, 2022

Got it! You should now be able to navigate to this file and hit the edit button to submit a pull request. This initial version will ship with the next release. Thanks!

@ben ben closed this as completed Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants