Run clippy and lint

bempp · Oct 25, 2024 · b477a3e · b477a3e
1 parent 814a20c
commit b477a3e
Show file tree

Hide file tree

Showing 7 changed files with 37 additions and 18 deletions.
diff --git a/kifmm/examples/mpi_test_fmm.rs b/kifmm/examples/mpi_test_fmm.rs
@@ -13,7 +13,10 @@ fn main() {
 
     use rayon::ThreadPoolBuilder;
 
-    use mpi::{datatype::PartitionMut, traits::*};
+    use mpi::{
+        datatype::PartitionMut,
+        traits::{Communicator, Root},
+    };
     use rlst::RawAccess;
 
     let (universe, _threading) = mpi::initialize_with_threading(mpi::Threading::Funneled).unwrap();
@@ -48,13 +51,13 @@ fn main() {
                 &comm,
                 points.data(),
                 points.data(),
-                local_depth.clone(),
-                global_depth.clone(),
+                local_depth,
+                global_depth,
                 prune_empty,
                 sort_kind.clone(),
             )
             .unwrap()
-            .parameters(expansion_order.clone(), kernel.clone(), source_to_target)
+            .parameters(expansion_order, kernel.clone(), source_to_target)
             .unwrap()
             .build()
             .unwrap();
@@ -161,13 +164,13 @@ fn main() {
                 &comm,
                 points.data(),
                 points.data(),
-                local_depth.clone(),
-                global_depth.clone(),
+                local_depth,
+                global_depth,
                 prune_empty,
                 sort_kind,
             )
             .unwrap()
-            .parameters(expansion_order.clone(), kernel, source_to_target)
+            .parameters(expansion_order, kernel, source_to_target)
             .unwrap()
             .build()
             .unwrap();

diff --git a/kifmm/examples/mpi_test_ghost_exchange.rs b/kifmm/examples/mpi_test_ghost_exchange.rs
@@ -19,7 +19,10 @@ fn main() {
 
     use rayon::ThreadPoolBuilder;
 
-    use mpi::{datatype::PartitionMut, traits::*};
+    use mpi::{
+        datatype::PartitionMut,
+        traits::{Communicator, Root},
+    };
     use rlst::RawAccess;
 
     let (universe, _threading) = mpi::initialize_with_threading(mpi::Threading::Single).unwrap();
@@ -282,7 +285,7 @@ fn main() {
                 assert!(
                     distributed_interaction_list.contains(s),
                     "Test failed: element {:?} is missing in distributed_interaction_list. at leaf: {:?} \n: {:?} = {:?} \n is it contained locally? {:?} or in ghost tree? {:?}",
-                    s, leaf.morton, i1, i2, multi_fmm.tree.source_tree.keys_set.contains(s), multi_fmm.ghost_fmm_u.tree.source_tree.keys_set.contains(&s)
+                    s, leaf.morton, i1, i2, multi_fmm.tree.source_tree.keys_set.contains(s), multi_fmm.ghost_fmm_u.tree.source_tree.keys_set.contains(s)
                 );
             }
 

diff --git a/kifmm/examples/mpi_test_layout.rs b/kifmm/examples/mpi_test_layout.rs
@@ -13,7 +13,11 @@ fn main() {
 
     use rayon::ThreadPoolBuilder;
 
-    use mpi::{collective::SystemOperation, datatype::PartitionMut, traits::*};
+    use mpi::{
+        collective::SystemOperation,
+        datatype::PartitionMut,
+        traits::{Communicator, CommunicatorCollectives},
+    };
     use rlst::RawAccess;
 
     let (universe, _threading) = mpi::initialize_with_threading(mpi::Threading::Single).unwrap();

diff --git a/kifmm/examples/mpi_test_p2m.rs b/kifmm/examples/mpi_test_p2m.rs
@@ -20,7 +20,10 @@ fn main() {
 
     use rayon::ThreadPoolBuilder;
 
-    use mpi::{datatype::PartitionMut, traits::*};
+    use mpi::{
+        datatype::PartitionMut,
+        traits::{Communicator, Root},
+    };
     use rlst::RawAccess;
 
     let (universe, _threading) = mpi::initialize_with_threading(mpi::Threading::Single).unwrap();

diff --git a/kifmm/examples/mpi_test_sort.rs b/kifmm/examples/mpi_test_sort.rs
@@ -16,7 +16,7 @@ mod mpi {
     }
 
     fn test_sort<T: Equivalence + Ord + Default + Clone + Copy>(
-        sorted_arr: &Vec<T>,
+        sorted_arr: &[T],
         comm: &SimpleCommunicator,
         label: String,
     ) {

diff --git a/kifmm/examples/mpi_test_trees.rs b/kifmm/examples/mpi_test_trees.rs
@@ -17,7 +17,10 @@ fn main() {
 
     use rayon::ThreadPoolBuilder;
 
-    use mpi::{datatype::PartitionMut, traits::*};
+    use mpi::{
+        datatype::PartitionMut,
+        traits::{Communicator, Root},
+    };
     use rlst::RawAccess;
 
     let (universe, _threading) = mpi::initialize_with_threading(mpi::Threading::Single).unwrap();
@@ -49,13 +52,13 @@ fn main() {
             &comm,
             points.data(),
             points.data(),
-            local_depth.clone(),
-            global_depth.clone(),
+            local_depth,
+            global_depth,
             prune_empty,
             sort_kind,
         )
         .unwrap()
-        .parameters(expansion_order.clone(), kernel, source_to_target)
+        .parameters(expansion_order, kernel, source_to_target)
         .unwrap()
         .build()
         .unwrap();

diff --git a/kifmm/examples/mpi_test_upward_pass.rs b/kifmm/examples/mpi_test_upward_pass.rs
@@ -13,7 +13,10 @@ fn main() {
         // FftFieldTranslation,
     };
     use kifmm::{BlasFieldTranslationSaRcmp, FmmSvdMode};
-    use mpi::{datatype::PartitionMut, traits::*};
+    use mpi::{
+        datatype::PartitionMut,
+        traits::{Communicator, Root},
+    };
     use rlst::{RawAccess, RlstScalar};
 
     let (universe, _threading) = mpi::initialize_with_threading(mpi::Threading::Funneled).unwrap();
@@ -86,7 +89,7 @@ fn main() {
 
     fmm.kernel().evaluate_st(
         GreenKernelEvalType::Value,
-        &coords,
+        coords,
         &distant_point,
         &charges,
         &mut expected,