-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Optional26 to Optional #102
Conversation
Remove the target ship date from the name of the project.
Link this PR to bemanproject/beman#85 |
@steve-downey , can we merge this please? (if no harm to other urgent PRs) We would like to advance with bemanproject/beman#85. |
FYI. I renamed the repo. CC: @steve-downey |
You'll also need to fix the coveralls CI, I think?
…On Tue, Jan 21, 2025, 08:11 Darius Neațu ***@***.***> wrote:
FYI. I renamed the repo. CC: @steve-downey
<https://github.com/steve-downey>
—
Reply to this email directly, view it on GitHub
<#102 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVNZ5QFOJTY73KLVHO6RT32LZBRFAVCNFSM6AAAAABVN7E3RKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBUGY4TMMZQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I'll add to my list. Can you point to the place where I should check it? |
Missed that. I was under the impression that ci.yaml was completely updated in your PR. #104 here is the fix. |
The problem is that the repository name is external to the repo, except for
this where coveralls needs to find the file.
Figured this out because I haven't been constantly renaming my fork and
coveralls coverage has been broken there.
…On Tue, Jan 21, 2025, 08:50 Darius Neațu ***@***.***> wrote:
Missed that. I was under the impression that ci.yaml was completely
updated in your PR. #104
<#104> here is the fix.
—
Reply to this email directly, view it on GitHub
<#102 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVNZ5TFTVDPMCJSW4QHNBD2LZGCHAVCNFSM6AAAAABVN7E3RKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBUG44TCNJZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Remove the target ship date from the name of the project.