Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Optional26 to Optional #102

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Conversation

steve-downey
Copy link
Member

Remove the target ship date from the name of the project.

Remove the target ship date from the name of the project.
@coveralls
Copy link

coveralls commented Jan 18, 2025

Coverage Status

coverage: 93.333%. remained the same
when pulling fa78a64 on steve-downey:remove-26
into 8db85ce on bemanproject:main.

@neatudarius
Copy link
Member

Link this PR to bemanproject/beman#85

@neatudarius
Copy link
Member

@steve-downey , can we merge this please? (if no harm to other urgent PRs) We would like to advance with bemanproject/beman#85.

@steve-downey steve-downey merged commit 51bb4c6 into bemanproject:main Jan 21, 2025
8 checks passed
@neatudarius
Copy link
Member

neatudarius commented Jan 21, 2025

FYI. I renamed the repo. CC: @steve-downey

@steve-downey
Copy link
Member Author

steve-downey commented Jan 21, 2025 via email

@neatudarius
Copy link
Member

You'll also need to fix the coveralls CI, I think?

On Tue, Jan 21, 2025, 08:11 Darius Neațu @.> wrote: FYI. I renamed the repo. CC: @steve-downey https://github.com/steve-downey — Reply to this email directly, view it on GitHub <#102 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVNZ5QFOJTY73KLVHO6RT32LZBRFAVCNFSM6AAAAABVN7E3RKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBUGY4TMMZQGI . You are receiving this because you were mentioned.Message ID: @.>

I'll add to my list. Can you point to the place where I should check it?

@steve-downey
Copy link
Member Author

steve-downey commented Jan 21, 2025 via email

@neatudarius
Copy link
Member

Missed that. I was under the impression that ci.yaml was completely updated in your PR. #104 here is the fix.

@steve-downey
Copy link
Member Author

steve-downey commented Jan 21, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants