Introduce CMake toolchain #76
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| # This toolchain file is not meant to be used directly, | ||
| # but to be invoked by CMake preset and GitHub CI. | ||
| # | ||
| # This toolchain file configures for apple clang family of compiler. | ||
| # Note this is different from LLVM toolchain. | ||
| # | ||
| # BEMAN_BUILDSYS_SANITIZER: | ||
| # This optional CMake parameter is not meant for public use and is subject to | ||
| # change. | ||
| # Possible values: | ||
| # - MaxSan: configures clang and clang++ to use all available non-conflicting | ||
| # sanitizers. Note that apple clang does not support leak sanitizer. | ||
| # - TSan: configures clang and clang++ to enable the use of thread sanitizer. | ||
|
|
||
| set(CMAKE_C_COMPILER clang) | ||
| set(CMAKE_CXX_COMPILER clang++) | ||
|
|
||
| if(BEMAN_BUILDSYS_SANITIZER STREQUAL "MaxSan") | ||
| set(SANITIZER_FLAGS | ||
| "-fsanitize=address -fsanitize=pointer-compare -fsanitize=pointer-subtract -fsanitize=undefined" | ||
| ) | ||
| elseif(BEMAN_BUILDSYS_SANITIZER STREQUAL "TSan") | ||
| set(SANITIZER_FLAGS "-fsanitize=thread") | ||
| endif() | ||
|
|
||
| set(CMAKE_C_FLAGS_DEBUG_INIT "${SANITIZER_FLAGS}") | ||
| set(CMAKE_CXX_FLAGS_DEBUG_INIT "${SANITIZER_FLAGS}") | ||
|
|
||
| set(RELEASE_FLAG "-O3 ${SANITIZER_FLAGS}") | ||
|
There was a problem hiding this comment. FLAG -> FLAGS to match the existing CMake conventions. |
||
|
|
||
| set(CMAKE_C_FLAGS_RELWITHDEBINFO_INIT "${RELEASE_FLAG}") | ||
| set(CMAKE_CXX_FLAGS_RELWITHDEBINFO_INIT "${RELEASE_FLAG}") | ||
|
|
||
| set(CMAKE_C_FLAGS_RELEASE_INIT "${RELEASE_FLAG}") | ||
| set(CMAKE_CXX_FLAGS_RELEASE_INIT "${RELEASE_FLAG}") | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| # This toolchain file is not meant to be used directly, | ||
| # but to be invoked by CMake preset and GitHub CI. | ||
| # | ||
| # This toolchain file configures for GNU family of compiler. | ||
| # | ||
| # BEMAN_BUILDSYS_SANITIZER: | ||
| # This optional CMake parameter is not meant for public use and is subject to | ||
| # change. | ||
| # Possible values: | ||
| # - MaxSan: configures gcc and g++ to use all available non-conflicting | ||
| # sanitizers. | ||
| # - TSan: configures gcc and g++ to enable the use of thread sanitizer | ||
|
|
||
| set(CMAKE_C_COMPILER gcc) | ||
wusatosi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| set(CMAKE_CXX_COMPILER g++) | ||
|
|
||
| if(BEMAN_BUILDSYS_SANITIZER STREQUAL "MaxSan") | ||
| set(SANITIZER_FLAGS | ||
| "-fsanitize=address -fsanitize=leak -fsanitize=pointer-compare -fsanitize=pointer-subtract -fsanitize=undefined" | ||
| ) | ||
| elseif(BEMAN_BUILDSYS_SANITIZER STREQUAL "TSan") | ||
| set(SANITIZER_FLAGS "-fsanitize=thread") | ||
| endif() | ||
|
|
||
| set(CMAKE_C_FLAGS_DEBUG_INIT "${SANITIZER_FLAGS}") | ||
| set(CMAKE_CXX_FLAGS_DEBUG_INIT "${SANITIZER_FLAGS}") | ||
|
|
||
| set(RELEASE_FLAG "-O3 ${SANITIZER_FLAGS}") | ||
|
|
||
| set(CMAKE_C_FLAGS_RELWITHDEBINFO_INIT "${RELEASE_FLAG}") | ||
| set(CMAKE_CXX_FLAGS_RELWITHDEBINFO_INIT "${RELEASE_FLAG}") | ||
|
|
||
| set(CMAKE_C_FLAGS_RELEASE_INIT "${RELEASE_FLAG}") | ||
| set(CMAKE_CXX_FLAGS_RELEASE_INIT "${RELEASE_FLAG}") | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
camio marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| # This toolchain file is not meant to be used directly, | ||
| # but to be invoked by CMake preset and GitHub CI. | ||
| # | ||
| # This toolchain file configures for LLVM family of compiler. | ||
| # | ||
| # BEMAN_BUILDSYS_SANITIZER: | ||
| # This optional CMake parameter is not meant for public use and is subject to | ||
| # change. | ||
| # Possible values: | ||
| # - MaxSan: configures clang and clang++ to use all available non-conflicting | ||
| # sanitizers. | ||
| # - TSan: configures clang and clang++ to enable the use of thread sanitizer. | ||
|
|
||
| set(CMAKE_C_COMPILER clang) | ||
| set(CMAKE_CXX_COMPILER clang++) | ||
|
|
||
| if(BEMAN_BUILDSYS_SANITIZER STREQUAL "MaxSan") | ||
| set(SANITIZER_FLAGS | ||
| "-fsanitize=address -fsanitize=leak -fsanitize=pointer-compare -fsanitize=pointer-subtract -fsanitize=undefined" | ||
| ) | ||
| elseif(BEMAN_BUILDSYS_SANITIZER STREQUAL "TSan") | ||
| set(SANITIZER_FLAGS "-fsanitize=thread") | ||
| endif() | ||
|
|
||
| set(CMAKE_C_FLAGS_DEBUG_INIT "${SANITIZER_FLAGS}") | ||
| set(CMAKE_CXX_FLAGS_DEBUG_INIT "${SANITIZER_FLAGS}") | ||
|
|
||
| set(RELEASE_FLAG "-O3 ${SANITIZER_FLAGS}") | ||
|
|
||
| set(CMAKE_C_FLAGS_RELWITHDEBINFO_INIT "${RELEASE_FLAG}") | ||
| set(CMAKE_CXX_FLAGS_RELWITHDEBINFO_INIT "${RELEASE_FLAG}") | ||
|
|
||
| set(CMAKE_C_FLAGS_RELEASE_INIT "${RELEASE_FLAG}") | ||
| set(CMAKE_CXX_FLAGS_RELEASE_INIT "${RELEASE_FLAG}") | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| # This toolchain file is not meant to be used directly, | ||
| # but to be invoked by CMake preset and GitHub CI. | ||
| # | ||
| # This toolchain file configures for MSVC family of compiler. | ||
| # | ||
| # BEMAN_BUILDSYS_SANITIZER: | ||
| # This optional CMake parameter is not meant for public use and is subject to | ||
| # change. | ||
| # Possible values: | ||
| # - MaxSan: configures cl to use all available non-conflicting sanitizers. | ||
| # | ||
| # Note that in other toolchain files, TSan is also a possible value for | ||
| # BEMAN_BUILDSYS_SANITIZER, however, MSVC does not support thread sanitizer, | ||
| # thus this value is omitted. | ||
|
|
||
| set(CMAKE_C_COMPILER cl) | ||
| set(CMAKE_CXX_COMPILER cl) | ||
|
|
||
| if(BEMAN_BUILDSYS_SANITIZER STREQUAL "MaxSan") | ||
| set(SANITIZER_FLAGS "/fsanitize=address /Zi") | ||
| endif() | ||
|
|
||
| set(CMAKE_CXX_FLAGS_DEBUG_INIT "/EHsc /permissive- ${SANITIZER_FLAGS}") | ||
| set(CMAKE_C_FLAGS_DEBUG_INIT "/EHsc /permissive- ${SANITIZER_FLAGS}") | ||
|
|
||
| set(RELEASE_FLAG "/EHsc /permissive- /O2 ${SANITIZER_FLAGS}") | ||
|
|
||
| set(CMAKE_C_FLAGS_RELWITHDEBINFO_INIT "${RELEASE_FLAG}") | ||
| set(CMAKE_CXX_FLAGS_RELWITHDEBINFO_INIT "${RELEASE_FLAG}") | ||
|
|
||
| set(CMAKE_C_FLAGS_RELEASE_INIT "${RELEASE_FLAG}") | ||
| set(CMAKE_CXX_FLAGS_RELEASE_INIT "${RELEASE_FLAG}") |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this variable should be prefixed with
BEMAN_BUILDSYS_to avoid conflicts with project variables.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only meant to be a local variable and not to be exported. I will see if I can make it so that it's treated like a local variable.