Runtime lint: Warning about class or data-bem in attrs
#349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadatuta
requested changes
Sep 20, 2016
| if (attrs.class) { | ||
| console.warn( | ||
| '\nBEM-XJST WARNING: looks like you try to set HTML class from attrs field in BEMJSON. ' + | ||
| 'Please you cls() mode for it. See documentation: https://github.com/bem/bem-xjst/blob/master/docs/en/5-templates-syntax.md#cls' + |
|
|
||
| if (attrs.class) { | ||
| console.warn( | ||
| '\nBEM-XJST WARNING: looks like you try to set HTML class from attrs field in BEMJSON. ' + |
|
|
||
| if (attrs['data-bem']) { | ||
| console.warn( | ||
| '\nBEM-XJST WARNING: looks like you try to set data-bem attribute from attrs field in BEMJSON. ' + |
| if (attrs['data-bem']) { | ||
| console.warn( | ||
| '\nBEM-XJST WARNING: looks like you try to set data-bem attribute from attrs field in BEMJSON. ' + | ||
| 'Please you js() mode for it. See documentation: https://github.com/bem/bem-xjst/blob/master/docs/en/5-templates-syntax.md#js' + |
miripiruni
force-pushed
the
issue-212__attrs-runtime-lint
branch
2 times, most recently
from
5f18f48
to
0423826
Compare
miripiruni
force-pushed
the
issue-212__attrs-runtime-lint
branch
from
0423826
to
9aacd91
Compare
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #212