i-bem: setMod/hasMod convert non-boolean values to string

[narqo]

closes #890

/cc @dfilatov

[coveralls]

Coverage increased (+0.05%) to 83.52% when pulling 47414ea on issues/890@v2 into 7947ae6 on v2.

[dfilatov]

commit title doesn't correspond its content

[dfilatov]

I have two points about that:

• jsdoc said that it took String param. So passing Number to it can't be treated as a bug.
• we have only special case —Boolean, so we should explicitly cast to String any other values, not just Number.

[coveralls]

Coverage increased (+0.05%) to 83.52% when pulling 25ff8d1 on issues/890@v2 into 7947ae6 on v2.

[dfilatov]

@narqo ping

[narqo]

jsdoc said that it took String param. So passing Number to it can't be treated as a bug.

Agree with it. But at the same time I'd prefer to have a warnings (or an error) about such things. Currently it not that obvious, how that code works.

[..] so we should explicitly cast to String any other values, not just Number.

I think I haven't understood your point. Which other types in addition to String and Number do you mean?

BTW, we've fixed jsdoc of these methods as well.

[dfilatov]

I think I haven't understood your point. Which other types in addition to String and Number do you mean?

I mean we don't need to explicitly consider Number as a special case. Boolean (and maybe undefined) is only special case. For any other values we should just call .toString().

[qfox]

Propose {Boolean|*} for type (or {?} if we want to do here #893). And description: true or undefined would be treated as "true" string.
But what about false?

[dfilatov]

No, undefined should not be treated as true, especially as string, setMod(modName, undefined) is equivalent of deleting this mod.
In case of setMod(modName) modVal should be treated as Boolean true.

[qfox]

@dfilatov Sorry, I meant #892

[dfilatov]

@zxqfox Do you ever sleep? )

[qfox]

@dfilatov Should I? ;-)

[narqo]

🆙

[narqo]

@dfilatov pong

[dfilatov]

double space before modVal

[dfilatov]

lgtm

[dfilatov]

don't forget about v3, will you?