jquery__pointernative: pointerenter / pointerleave events bubble up to the document root #802
Conversation
|
Note, the only browsers I've tested it are Chrome and Fx. |
|
Could you add spec for |
|
@dfilatov we already had simple tests for 🆙 |
|
BTW: It seems that no one of currently popular Pointer Events Polyfils (MS, Polymer or jquery's PEP) would pass this test case, as they use native |
| var target = event.target, | ||
| relatedTarget = event.relatedTarget; | ||
|
|
||
| while(target && !this.contains(target, relatedTarget)) { |
There was a problem hiding this comment.
Isn't it expensive? contains has inner cycle as well
There was a problem hiding this comment.
Hm, yep, haven't thought about it :(
What if I rewrite it like this:
if(!this.contains(target, relatedTarget)) {
do {
event.target = target;
fn.call(this, event); // we need to emit non bubbling events here on the subtree from target to relatedTarget
} while(target = target.parentNode && target !== relatedTarget)
}?
to the document root fix #801
|
🆙 |
| this.enterLeave(event, this.enter); | ||
| }, | ||
|
|
||
| enterLeave : function(event, fn) { |
There was a problem hiding this comment.
I don't like the name of the method, but I couldn't decide how to call it :(
|
👍 |
|
@narqo Don't forget do the same PR to v3 |
jquery__pointernative: pointerenter / pointerleave events bubble up to the document root
fix #801
/cc @dfilatov