Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old junk #1308

Merged
merged 5 commits into from
Apr 12, 2016
Merged

Remove old junk #1308

merged 5 commits into from
Apr 12, 2016

Conversation

tadatuta
Copy link
Member

  1. Drop BEMHTML and BEMTREE base templates
  2. Drop documentation for bem-xjst
  3. Drop i-bem__i18n
  4. Update npm dependencies and build scrips
  5. Rename *.bemhtml to *.bemhtml.js

Closes (for v3):

@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.828% when pulling 41c31f7 on removeJunk@v3 into 2c05fd4 on v3.

@tadatuta
Copy link
Member Author

cc @narqo @veged

@tadatuta tadatuta mentioned this pull request Apr 12, 2016
Merged
@veged
Copy link
Member

veged commented Apr 12, 2016

LGTM

@tadatuta tadatuta merged commit 996841c into v3 Apr 12, 2016
@tadatuta tadatuta removed the ready label Apr 12, 2016
@tadatuta tadatuta deleted the removeJunk@v3 branch April 12, 2016 15:21
@narqo narqo mentioned this pull request Apr 12, 2016
Closed
@narqo
Copy link
Member

narqo commented Apr 12, 2016

Please backport it to v4 immediately. Nobody wants be repeat #1293

@tadatuta tadatuta mentioned this pull request Apr 12, 2016
Merged
@tadatuta
Copy link
Member Author

@narqo #1312

tadatuta added a commit that referenced this pull request Apr 20, 2016
@tadatuta
Merge pull request #1312 from /pull/1308@v4
850d41f 
Drop xjst base tmpls and i-bem__i18n, introduce i18n, update infra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tadatuta @coveralls @veged @narqo