Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of buildEscape #982

Closed
sbmaxx opened this issue Apr 15, 2015 · 0 comments
Closed

Get rid of buildEscape #982

sbmaxx opened this issue Apr 15, 2015 · 0 comments
Labels
v2
Milestone
2.7

Comments

@sbmaxx
Copy link

sbmaxx commented Apr 15, 2015

Выпилить генератор escape-методов buildEscape
https://github.com/bem/bem-core/blob/v2/common.blocks/i-bem/i-bem.bemhtml#L152-L159, а также её производные https://github.com/bem/bem-core/blob/v2/common.blocks/i-bem/i-bem.bemhtml#L228-L229

В пользу заранее скопипащенных функций. Добавит немного профита к скорости.

Я сделаю PR про это;)
@sbmaxx sbmaxx mentioned this issue Apr 15, 2015
Merged
@aristov aristov changed the title Get rid off buildEscape Get rid of buildEscape Apr 15, 2015
This was referenced Apr 17, 2015
Merged
Merged
@narqo narqo added the v2 label Apr 20, 2015
@narqo narqo added this to the 2.7 milestone Apr 20, 2015
narqo pushed a commit that referenced this issue Apr 20, 2015
@sbmaxx
get rid off buildEscape, #982
33a4eac
narqo pushed a commit that referenced this issue Apr 20, 2015
Merge pull request #986 from sbmaxx/issues/982@v2
b050b1a 
get rid off buildEscape, #982
@narqo narqo mentioned this issue May 19, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
2.7
Development

No branches or pull requests
2 participants
@narqo @sbmaxx