Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jquery__event_type_winresize: Fix typo #862

Closed
tadatuta opened this issue Feb 2, 2015 · 6 comments
Closed

jquery__event_type_winresize: Fix typo #862

tadatuta opened this issue Feb 2, 2015 · 6 comments

Comments

@tadatuta
Copy link
Member

tadatuta commented Feb 2, 2015

@dfilatov Dima, we have https://github.com/bem/bem-core/blob/v2/desktop.blocks/jquery/__event/_type/jquery__event_type_winresize.js in bem-core but it looks like it's not used anyway. Can't we just remove it?

@dfilatov
Copy link
Member

dfilatov commented Feb 2, 2015

It's used on projects which want to have proper resize in IE.

@tadatuta
Copy link
Member Author

tadatuta commented Feb 2, 2015

@dfilatov in this case should we replace 'ie' here with 'msie' as it's used in ua?

@dfilatov
Copy link
Member

dfilatov commented Feb 2, 2015

@tadatuta yep, definitely

@tadatuta tadatuta changed the title jquery__event_type_winresize: Is it really needed jquery__event_type_winresize: Fix typo Feb 2, 2015
@hcodes
Copy link
Contributor

hcodes commented Mar 5, 2015

Потестировал:
Нужно для IE8 и ниже, хотя проблемы могут быть и в IE9 и выше, если выбрать Document Mode - Internet Explorer 8 standarts.

Можно добавить условие (про IE=Edge знаю):

if(ua.msie && document.documentMode <= 8) {
}

и поправить TODO-комментарий.

https://msdn.microsoft.com/en-us/library/ie/ms536959%28v=vs.85%29.aspx

@narqo
Copy link
Member

narqo commented Mar 5, 2015

[..] и поправить TODO-комментарий

@hcodes можете с @tadatuta доделать #864 и #865?

@hcodes
Copy link
Contributor

hcodes commented Mar 5, 2015

@narqo доделал.

hcodes added a commit that referenced this issue Mar 6, 2015
jquery__event_type_winresize: ie -> msie
hcodes added a commit that referenced this issue Mar 6, 2015
jquery__event_type_winresize: ie -> msie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants