Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tick: stop method doesn't remove timer in some cases #694

Closed
tadatuta opened this issue Oct 10, 2014 · 1 comment
Closed

tick: stop method doesn't remove timer in some cases #694

tadatuta opened this issue Oct 10, 2014 · 1 comment
Assignees
@aristov
Labels
bug

Comments

@tadatuta
Copy link
Member

Now there's possibility to call timer.stop() without actually stopping timer.
That's because of _isStarted flag can be set to false at the moment when _timer is refering to previous instance.
@tadatuta tadatuta added the bug label Oct 10, 2014
@aristov aristov self-assigned this Oct 15, 2014
@hcodes
Copy link
Contributor

hcodes commented Oct 23, 2014

Closes #705

hcodes added a commit that referenced this issue Oct 23, 2014
@hcodes
tick: stop method won't be remove timer in some cases #694
77b6c7e
dfilatov added a commit that referenced this issue Oct 23, 2014
@dfilatov
Merge pull request #705 from /issues/694@v2
329af39 
tick: stop method won't be remove timer in some cases #694
hcodes added a commit that referenced this issue Oct 24, 2014
@hcodes
tick: stop method won't be remove timer in some cases #694
d771b2d
dfilatov added a commit that referenced this issue Oct 24, 2014
@dfilatov
Merge pull request #707 from /issues/694@v3
e69da23 
tick: stop method won't be remove timer in some cases #694
@hcodes hcodes closed this as completed Oct 24, 2014
@hcodes hcodes mentioned this issue Oct 28, 2014
Merged
@tadatuta tadatuta changed the title tick: stop method won't be remove timer in some cases tick: stop method won't remove timer in some cases Oct 28, 2014
@tadatuta tadatuta changed the title tick: stop method won't remove timer in some cases tick: stop method doesn't remove timer in some cases Oct 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aristov aristov

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hcodes @tadatuta @aristov