Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

page: Wrong user-scalable value in meta name=viewport on touch level #1294

Closed
narqo opened this issue Apr 5, 2016 · 1 comment
Closed

page: Wrong user-scalable value in meta name=viewport on touch level #1294

narqo opened this issue Apr 5, 2016 · 1 comment
Assignees
@narqo
Labels
bug HTML v2 v3 v4

Comments

@narqo
Copy link
Member

narqo commented Apr 5, 2016

https://github.com/bem/bem-core/blob/v2.9.0/touch.blocks/page/page.bh.js#L14-L20

page adds <meta name=viewport> with user-scalable=0 which is not a valid value.

See https://drafts.csswg.org/css-device-adapt/#user-scalable

The user-scalable property is translated into user-zoom with the following value translations.

  • yes and no are translated into zoom and fixed respectively.
  • Numbers ≥ 1, numbers ≤ -1, device-width and device-height are mapped to zoom
  • Numbers in the range (-1, 1), and unknown values, are mapped to fixed

The valid value is no.

/cc @doochik @tadatuta
@doochik
Copy link
Contributor

doochik commented Apr 5, 2016

This will fix bem/bem-components#1738 because fast click will be disabled for chrome on pages with meta user-scalable=no

doochik added a commit that referenced this issue Apr 5, 2016
@doochik
Wrong user-scalable value in meta name=viewport. Fix #1294
b591729 
According to the spec https://drafts.csswg.org/css-device-adapt/#user-scalable the valid value is `user-scalable=no`
@narqo narqo closed this as completed in 9988504 Apr 5, 2016
narqo pushed a commit that referenced this issue Apr 5, 2016
Merge pull request #1295 from bem/meta-wrong-user-scalable
8935e81 
Wrong user-scalable value in meta name=viewport. Fix #1294
@narqo narqo removed the in progress label Apr 5, 2016
@narqo narqo mentioned this issue Apr 5, 2016
Merged
@narqo narqo assigned narqo and unassigned doochik Apr 5, 2016
@narqo narqo mentioned this issue Apr 5, 2016
Merged
narqo pushed a commit that referenced this issue Apr 5, 2016
@doochik
Wrong user-scalable value in meta name=viewport. Fix #1294
913aab9 
According to the spec https://drafts.csswg.org/css-device-adapt/#user-scalable the valid value is `user-scalable=no`
narqo pushed a commit that referenced this issue Apr 5, 2016
Merge pull request #1297 from /issues/1294@v4
972e49d 
Wrong user-scalable value in meta name=viewport
narqo pushed a commit that referenced this issue Apr 5, 2016
@doochik
Wrong user-scalable value in meta name=viewport. Fix #1294
6a4dcf1 
According to the spec https://drafts.csswg.org/css-device-adapt/#user-scalable the valid value is `user-scalable=no`
narqo pushed a commit that referenced this issue Apr 5, 2016
Merge pull request #1296 from /issues/1294@v3
78c1f5e 
Wrong user-scalable value in meta name=viewport
veged pushed a commit that referenced this issue Apr 11, 2016
@doochik @qfox
Wrong user-scalable value in meta name=viewport. Fix #1294
95b4980 
According to the spec https://drafts.csswg.org/css-device-adapt/#user-scalable the valid value is `user-scalable=no`
qfox added a commit to bem/bem-core-php that referenced this issue Apr 12, 2016
@qfox
fix(page): invalid user-scalable value in meta name=viewport
a84641a 
Fixes bem/bem-core#1294
See bem/bem-core@9988504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@narqo narqo

Labels
bug HTML v2 v3 v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@doochik @narqo @tavriaforever