Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i-bem__dom: dropElemCache is broken? #1037

Closed
qfox opened this issue Jun 5, 2015 · 11 comments
Closed

i-bem__dom: dropElemCache is broken? #1037

qfox opened this issue Jun 5, 2015 · 11 comments
Assignees
@qfox
Labels
bug JS v2

Comments

@qfox
Copy link
Member

qfox commented Jun 5, 2015

Looks like it's broken, because it uses names + buildModPostfix(modName, modVal) instead of this.__self.buildClass(name, modName, modVal) that contains blockName.

/cc @Yeti-or
@qfox qfox mentioned this issue Jun 5, 2015
Closed
@levonet levonet added the ready label Jun 5, 2015
@qfox
Copy link
Member Author

qfox commented Jun 5, 2015

Wow, dat fight between @levonet and @tavriaforever.

@aristov
Copy link
Contributor

aristov commented Jun 6, 2015

Mad robots...

@dfilatov
Copy link
Member

dfilatov commented Jun 6, 2015

I can't wait until robots start writing code

@dfilatov
Copy link
Member

dfilatov commented Jun 6, 2015

@zxqfox I don't understand why cache key should contain blockName.

@qfox
Copy link
Member Author

qfox commented Jun 6, 2015

@dfilatov same here, but for now it looks like a bug.

@dfilatov
Copy link
Member

dfilatov commented Jun 6, 2015

@zxqfox Sorry, I can't make head or tail of what you have written. Could you explain?

@dfilatov
Copy link
Member

dfilatov commented Jun 8, 2015

ping

@qfox
Copy link
Member Author

qfox commented Jun 8, 2015

@dfilatov текущий dropElemCache работает только без параметров, потому что elem кеширует с названием блока, а первый удаляет без. Зачем там название блока — не знаю, в PR наименьшее кол-во измененного кода, по-хорошему, нужны тесты.

@Yeti-or
Copy link
Member

Yeti-or commented Jun 8, 2015

@dfilatov мы разбирали пр в bem-bl и выяснилось что dropElemCache не работает: bem/bem-bl#634

@dfilatov
Copy link
Member

dfilatov commented Jun 8, 2015

oк, теперь я понял

dfilatov added a commit that referenced this issue Jun 9, 2015
@dfilatov
Merge pull request #1042 from /issues/1037@v2
6792212 
i-bem__dom: fix dropElemCache logic (close #1038)
@narqo narqo added bug v2 and removed question labels Jun 10, 2015
@narqo
Copy link
Member

narqo commented Jun 10, 2015

Fixed with #1042

@narqo narqo closed this as completed Jun 10, 2015
@narqo narqo removed the in progress label Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qfox qfox

Labels
bug JS v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@dfilatov @narqo @qfox @tavriaforever @Yeti-or @aristov @levonet