Skip to content
This repository has been archived by the owner on Jan 13, 2018. It is now read-only.

Feature/bem mv@release 1.0.0 #502

Closed
wants to merge 4 commits into from
Closed

Feature/bem mv@release 1.0.0 #502

wants to merge 4 commits into from

Conversation

qfox
Copy link

@qfox qfox commented Nov 1, 2013

arikon and others added 4 commits November 2, 2013 02:39
@arikon
bem mv work in progress
6d8de8d 
Conflicts:
	lib/coa.js
	lib/util.js
	package.json
Implemented moving the file and added removeEmptryDirectory function
608e5b2 
Conflicts:
	package.json
Fixes Issue bem-archive#317
9a2aae4 
Details:
	* Adds getSelector() to tech.js to change content of target file
	* Support changing tech of BEM entities
	* Couple of fixes to previous patch

Conflicts:
	lib/commands/mv.js
	lib/tech/v1.js
Fixed flag on replace
a993d5f
@arikon
Copy link
Contributor

arikon commented Nov 2, 2013

The best way would be to factor this out as a separate package bem-mv. Like bem-version and bem-bench is.

@qfox
Copy link
Author

qfox commented Nov 4, 2013

@arikon Agreed but once again it will be hard to make without special api. We can't validate command, can't search block directory and their techs/deps if we can't take a look at projects levels, blocks in them, etc.
A lot of issues also waits for that API. For example #294, #369, etc.

@arikon
Copy link
Contributor

arikon commented Nov 13, 2013

@zxqfox As a workaround we could use require('bem') and use API that is already there. Like createLevel(), util and so on.

I should close this issue.

@tadatuta will create discussion board for us to start talking on bem2 and API.

@arikon arikon closed this Nov 13, 2013
@qfox
Copy link
Author

qfox commented Nov 13, 2013

@arikon Yes, sure.

@tadatuta tadatuta mentioned this pull request Nov 14, 2013
Open
@tadatuta tadatuta mentioned this pull request Dec 21, 2015
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qfox @arikon