This repository has been archived by the owner on Jan 13, 2018. It is now read-only.
Port V1 deps shortucts for tech and elems to V2 tech #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@SevInf Серёга, а тесты для этого есть? |
|
Для депсов v2 вообще тестов нет, как оказалось. Надо вместе с кем-то посидеть и посмотреть, можно ли класс Deps убрать из технологий и не дублировать его. В коде V2 есть отличия, но я не знаю, ломают ли они что-то в V1 или фиксят баги/добавляют фичи. |
|
@SevInf Тесты на deps.js v2 появляются в этих PR: |
|
@arikon готово |
arikon
added a commit
that referenced
this pull request
Oct 16, 2013
Port V1 deps shortucts for tech and elems to V2 tech
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #401, #413
/cc @arikon @dfilatov