This repository has been archived by the owner on Jan 13, 2018. It is now read-only.
Add ability to write level config module as a function (closes #364, BEM-931) #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,8 +8,18 @@ var PATH = require('./path'), | |||
| LOGGER = require('./logger'), | |||
| isRequireable = bemUtil.isRequireable, | |||
|
|
|||
| BEM, | |||
| getBem = function() { | |||
| if (!BEM) BEM = require('..'); | |||
There was a problem hiding this comment.
У require же свой кеш есть.
There was a problem hiding this comment.
Я знаю, не стал полагаться на то что он такой же легкий.
There was a problem hiding this comment.
Проверил: действительно твой вариант гораздо быстрее.
|
/сс @arikon |
| getLevelClass = function(path, optional) { | ||
| var level = optional && !isRequireable(path) ? {} : requireLevel(path); | ||
|
|
||
| if (typeof level === 'function') level = level(getBem()); |
There was a problem hiding this comment.
Напиши в комментариях в коде суть решения с getBem(). Я её понимаю, но кто-то при свежем взгляде в код может не понять.
|
Мне кажется эту фичу можно/нужно влить в 0.6 тоже? |
scf2k
added a commit
that referenced
this pull request
Sep 12, 2013
Add ability to write level config module as a function (closes #364, BEM-931)
scf2k
added a commit
that referenced
this pull request
Sep 16, 2013
Add ability to write level config module as a function (closes #364, BEM-931)
scf2k
added a commit
that referenced
this pull request
Sep 16, 2013
backport: Merge pull request #430 from bem/BEM-931
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.