This repository has been archived by the owner on Jan 13, 2018. It is now read-only.
Add ability to write tech module as a function (closes #363, BEM-930) #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!BEM) BEM = require('../..'); | ||
|
|
||
| return BEM; | ||
| }; |
There was a problem hiding this comment.
@scf2k Для чего это сделано?
There was a problem hiding this comment.
Просто пдключить bem в этом файле нельзя из-за цикличной зависимости.
|
/cc @arikon |
|
lgtm |
SevInf
pushed a commit
that referenced
this pull request
Sep 11, 2013
Add ability to write tech module as a function (closes #363, BEM-930)
|
|
||
| var tech = typeof module === 'string'? require(module) : module; | ||
|
|
||
| if (typeof tech === 'function') tech = tech(getBem()); |
There was a problem hiding this comment.
По коду не хватает комментариев, говорящих о том, что делает каждая волшебная строчка.
SevInf
pushed a commit
that referenced
this pull request
Sep 13, 2013
Add ability to write tech module as a function (closes #363, BEM-930) Conflicts: lib/tech/index.js test/tech.js
|
Changes Unknown when pulling a3d5bc8 on BEM-930 into * on release-1.0.0*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.