-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid Generator Version 2 #8
Draft
GalenReich
wants to merge
12
commits into
main
Choose a base branch
from
development
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d conversions from leaflet to turf
GalenReich
added
bug
Something isn't working
enhancement
New feature or request
help wanted
Extra attention is needed
labels
Aug 7, 2024
This was
linked to
issues
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
enhancement
New feature or request
help wanted
Extra attention is needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the working pull request for tying issues into a version 2 release.
Broadly the goal for version 2 is to add polygon functionality #2, support grid preview #4, and fix the issues with leaflet and vue #5
As we go I'm sure more functionality will pop up, and we can fold useful things into the V2 release.
A key principle is that we should continue to support the current functionality - users should be able to generate a grid with a single click. After the excellent work of #7 to add other functionality, this is not the case.
So just a bit of work needed here to test the new code and support the simple rectangle-based workflow.
And if you see this and think you could help - get involved! 🚀