-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
universe/go: enable all setgid tests again
[ commit 68b45368dd53d570477e8c14cef83a33a2b2d886 ] Apart from Test9400 there are additional tests which were disabled on Alpine and should now just pass with recent musl libc. See: golang/go#39857 (comment)
- Loading branch information
Showing
3 changed files
with
54 additions
and
33 deletions.
There are no files selected for viewing
31 changes: 0 additions & 31 deletions
31
universe/go/0002-misc-cgo-test-enable-Test9400-on-Alpine-Linux-again.patch
This file was deleted.
Oops, something went wrong.
52 changes: 52 additions & 0 deletions
52
universe/go/0002-misc-cgo-test-enable-setgid-tests-on-Alpine-Linux-ag.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
From b10f7f53b8a2b5d050b87072672bd7dfb79d6c1e Mon Sep 17 00:00:00 2001 | ||
From: =?UTF-8?q?S=C3=B6ren=20Tempel?= <[email protected]> | ||
Date: Wed, 7 Jun 2023 23:42:05 +0200 | ||
Subject: [PATCH] misc/cgo/test: enable setgid tests on Alpine Linux again | ||
|
||
The underlying issue has been fixed in musl. | ||
--- | ||
src/cmd/cgo/internal/test/cgo_linux_test.go | 10 ---------- | ||
1 file changed, 10 deletions(-) | ||
|
||
diff --git a/src/cmd/cgo/internal/test/cgo_linux_test.go b/src/cmd/cgo/internal/test/cgo_linux_test.go | ||
index 3defc32ffd..21b1feb5d1 100644 | ||
--- a/src/cmd/cgo/internal/test/cgo_linux_test.go | ||
+++ b/src/cmd/cgo/internal/test/cgo_linux_test.go | ||
@@ -7,7 +7,6 @@ | ||
package cgotest | ||
|
||
import ( | ||
- "os" | ||
"runtime" | ||
"testing" | ||
) | ||
@@ -16,9 +15,6 @@ func TestSetgid(t *testing.T) { | ||
if runtime.GOOS == "android" { | ||
t.Skip("unsupported on Android") | ||
} | ||
- if _, err := os.Stat("/etc/alpine-release"); err == nil { | ||
- t.Skip("setgid is broken with musl libc - go.dev/issue/39857") | ||
- } | ||
testSetgid(t) | ||
} | ||
|
||
@@ -26,9 +22,6 @@ func TestSetgidStress(t *testing.T) { | ||
if runtime.GOOS == "android" { | ||
t.Skip("unsupported on Android") | ||
} | ||
- if _, err := os.Stat("/etc/alpine-release"); err == nil { | ||
- t.Skip("setgid is broken with musl libc - go.dev/issue/39857") | ||
- } | ||
testSetgidStress(t) | ||
} | ||
|
||
@@ -36,9 +29,6 @@ func Test1435(t *testing.T) { test1435(t) } | ||
func Test6997(t *testing.T) { test6997(t) } | ||
|
||
func Test9400(t *testing.T) { | ||
- if _, err := os.Stat("/etc/alpine-release"); err == nil { | ||
- t.Skip("setgid is broken with musl libc - go.dev/issue/39857") | ||
- } | ||
test9400(t) | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters