fix: Add droppable state for booleans when mapping (n8n-io#5838)

believe-Mahesh · Apr 4, 2023 · 76b9dee · 76b9dee
1 parent 12cae8d
commit 76b9dee
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 0 deletions.
diff --git a/cypress/e2e/14-mapping.cy.ts b/cypress/e2e/14-mapping.cy.ts
@@ -291,4 +291,31 @@ describe('Data mapping', () => {
 			.should('have.text', '{{ $json.input[0].count }} {{ $json.input }}');
 		ndv.getters.parameterExpressionPreview('value').should('include.text', '0 [object Object]');
 	});
+
+	it('shows you can drop to inputs, including booleans', () => {
+		cy.fixture('Test_workflow_3.json').then((data) => {
+			cy.get('body').paste(JSON.stringify(data));
+		});
+
+		workflowPage.actions.openNode('Set');
+		ndv.actions.clearParameterInput('value');
+		cy.get('body').type('{esc}');
+
+		ndv.getters.parameterInput('keepOnlySet').find('input[type="checkbox"]').should('exist');
+		ndv.getters.parameterInput('keepOnlySet').find('input[type="text"]').should('not.exist');
+		ndv.getters.inputDataContainer().should('exist').find('span').contains('count').realMouseDown().realMouseMove(100, 100);
+		cy.wait(50);
+
+		ndv.getters.parameterInput('keepOnlySet').find('input[type="checkbox"]').should('not.exist');
+		ndv.getters.parameterInput('keepOnlySet').find('input[type="text"]')
+			.should('exist')
+			.invoke('css', 'border')
+			.then((border) => expect(border).to.include('1.5px dashed rgb(90, 76, 194)'));
+
+		ndv.getters.parameterInput('value').find('input[type="text"]')
+		.should('exist')
+		.invoke('css', 'border')
+		.then((border) => expect(border).to.include('1.5px dashed rgb(90, 76, 194)'));
+	});
+
 });
diff --git a/packages/editor-ui/src/components/ParameterInput.vue b/packages/editor-ui/src/components/ParameterInput.vue
@@ -298,6 +298,14 @@
 				</n8n-option>
 			</n8n-select>
 
+			<!-- temporary state of booleans while data is mapped -->
+			<n8n-input
+				v-else-if="parameter.type === 'boolean' && droppable"
+				:size="inputSize"
+				:value="JSON.stringify(displayValue)"
+				:disabled="isReadOnly"
+				:title="displayTitle"
+			/>
 			<el-switch
 				v-else-if="parameter.type === 'boolean'"
 				class="switch-input"