Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vite app example #661

Merged
merged 67 commits into from
Oct 27, 2021
Merged

Add Vite app example #661

merged 67 commits into from
Oct 27, 2021

Conversation

ekafyi
Copy link
Contributor

@ekafyi ekafyi commented Oct 24, 2021

I posted about this a while ago but had only been able to come back to this just now.

This PR adds a sample app based on the official Vite react-ts starter template. Might be useful for those who want to make a simple website that does not need Next.js' full features.

Caveats/shortcomings:

  • No test. I tried implementing Jest testing but was unable to make it work.
  • TS throws import/no-unresolved error due to some ESLint config, not just in this app but also in the Next.js app. The imports work correctly despite the TS error.

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2021

🦋 Changeset detected

Latest commit: ac2e49a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @belgattitude on Vercel.

@belgattitude first needs to authorize it.

@codeclimate
Copy link

codeclimate bot commented Oct 24, 2021

Code Climate has analyzed commit ac2e49a and detected 0 issues on this pull request.

View more on Code Climate.

@belgattitude
Copy link
Owner

@ekafyi, thanks.

TS throws import/no-unresolved error due to some ESLint config, not just in this app but also in the Next.js app. The imports work correctly despite the TS error.

Nice spot, I can't reproduce on linux or CI... but definitely I think there's something wrong with the config (are you on a mac ?)

I haven't looked at the code yet but I'm okay to merge it, cause it's fun 😄

I suggest this,

  • add a changeset, so we have a changelog with your name. to do so: in the root folder, type yarn changeset add a title like 'Vite app example added' and commit the generated file.

  • if you agree I'd like to co-author this P/R and add the eslint config, I'll prepare a P/R that we can merge part of your

Let me know if you're fine with this and we'll merge this week.

@ekafyi
Copy link
Contributor Author

ekafyi commented Oct 25, 2021

Changeset added! (I have never used it before, looks like a brilliantly practical system for versioning/publishing.)

renovate-bot and others added 17 commits October 26, 2021 22:49
chore(deps): update dependency eslint-config-next to v12
fix(deps): update dependency react-query to v3.29.0
chore(deps): update dependency lint-staged to v11.2.6
fix(deps): update dependency graphql to v15.7.0
chore(deps): update dependency sass to v1.43.4
chore(deps): update nextjs monorepo to v12.0.1
fix(deps): update dependency @mui/material to v5.0.6
…ules-9.x

fix(deps): update dependency next-transpile-modules to v9
fix(deps): update dependency type-fest to v2.5.2
…xp-1.x

chore(deps): update dependency eslint-plugin-regexp to v1.5.0
@belgattitude
Copy link
Owner

@ekafyi I've changed few things, can you rebase with main branch ? and generate a new yarn.lock

Would be awesome, thanks

@ekafyi
Copy link
Contributor Author

ekafyi commented Oct 27, 2021

Done!
(Btw I see the Next.js apps have been updated to v12.0 already, nice!)

@belgattitude
Copy link
Owner

yep 😄

I'll merge, the reason why the ci fail is not clear but I'll P/R a fix just after

There's probably a missing

yarn install && yarn dedupe

@belgattitude belgattitude merged commit 015b632 into belgattitude:main Oct 27, 2021
@github-actions github-actions bot mentioned this pull request Oct 27, 2021
@belgattitude
Copy link
Owner

Hey with the changeset, you'll be in the changelog... it's fully automated #697.

Nice 😄

@github-actions github-actions bot mentioned this pull request Oct 27, 2021
@ekafyi ekafyi deleted the add-vite-app-example branch October 28, 2021 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants