Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp fix graphql mesh (bad upgrade) #3733

Merged
merged 3 commits into from
Apr 30, 2023
Merged

Temp fix graphql mesh (bad upgrade) #3733

merged 3 commits into from
Apr 30, 2023

Conversation

belgattitude
Copy link
Owner

@belgattitude belgattitude commented Apr 30, 2023

Following wrong release versions in @graphql-mesh... see ardatan/graphql-mesh#5377

The idea is to only install

yarn add graphql @graphql-mesh/openapi @graphql-mesh/runtime @graphql-mesh/cli

as deps.

Drawback: Size in consuming apps (node_modules/lambda size) - consuming apps does not need to have all of that when the use the dist (vercel has standalone that will probably remove most the unused code)

By analyzing the dist folder... we actually should have these package installed (as peers or direct dependencies of api-gateway). But it will be harder to maintain with npm-check-updates or renovatebot... Cause some of them have been published to v1.0.0 and actually their latest versions is lower.

@graphql-mesh/runtime
@graphql-mesh/types
@graphql-mesh/utils
@graphql-mesh/cache-localforage
@graphql-mesh/openapi
@graphql-mesh/merger-bare
@graphql-mesh/http
@graphql-mesh/store
@graphql-mesh/cross-helpers

@whatwg-node/fetch

Todo need to see how pnpm will work

@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2023

⚠️ No Changeset found

Latest commit: beb8d00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
monorepo-nextjs-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2023 4:00pm
monorepo-vite-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2023 4:00pm

@codeclimate
Copy link

codeclimate bot commented Apr 30, 2023

Code Climate has analyzed commit beb8d00 and detected 0 issues on this pull request.

View more on Code Climate.

@ghost
Copy link

ghost commented Apr 30, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant