Skip to content

Commit

Permalink
Merge pull request #65 from belgattitude/minor-deps-typecheck
Browse files Browse the repository at this point in the history 
Minor deps typecheck
  • Loading branch information
@belgattitude
belgattitude authored May 25, 2021
2 parents abaf2e8 + 7295e8c commit fafaef8
Show file tree
Hide file tree
Showing 8 changed files with 178 additions and 196 deletions.
4 changes: 2 additions & 2 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,10 @@ See the global [static](./static) folder.
7. Be sure your next.config.js app overrides webpack like in [nextjs.config.js](./apps/web-app/next.config.js):
```js
webpack: function (config, { defaultLoaders }) {
const resolvedBaseUrl = path.resolve(config.context, '../../');
webpack: function(config, { defaultLoaders }) {
// Will allow transpilation of shared packages through tsonfig paths
// @link https://github.com/vercel/next.js/pull/13542
const resolvedBaseUrl = path.resolve(config.context, '../../');
config.module.rules = [
...config.module.rules,
{
Expand Down
2 changes: 1 addition & 1 deletion apps/blog-app/next.config.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ const config = withBundleAnalyzer(
},

webpack: function (config, { defaultLoaders }) {
const resolvedBaseUrl = path.resolve(config.context, '../../');
// This extra config allows to use paths defined in tsconfig
// rather than next-transpile-modules.
// @link https://github.com/vercel/next.js/pull/13542
const resolvedBaseUrl = path.resolve(config.context, '../../');
config.module.rules = [
...config.module.rules,
{
Expand Down
22 changes: 11 additions & 11 deletions apps/blog-app/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,31 +28,31 @@
"test": "run-s 'test:*'",
"test:unit": "jest --config jest.config.js --maxWorkers=50% --color $@",
"ci-test:unit": "jest --config jest.config.js --runInBand --color $@",
"typecheck": "tsc -p ./ --noEmit",
"typecheck": "tsc --project ./tsconfig.json --noEmit",
"lint": "eslint . --ext .ts,.tsx,.js,.jsx",
"fix:staged-files": "lint-staged --allow-empty",
"fix:all-files": "eslint . --ext .ts,.tsx,.js,.jsx --fix",
"postinstall": "yarn share:static:symlink"
},
"devDependencies": {
"@emotion/babel-plugin": "^11.3.0",
"@next/bundle-analyzer": "^10.2.2",
"@tailwindcss/typography": "^0.4.0",
"@next/bundle-analyzer": "^10.2.3",
"@tailwindcss/typography": "^0.4.1",
"@testing-library/jest-dom": "^5.12.0",
"@testing-library/react": "^11.2.7",
"@testing-library/react-hooks": "^6.0.0",
"@types/jest": "^26.0.23",
"@types/node": "^15.6.0",
"@types/react": "^17.0.6",
"@types/node": "^15.6.1",
"@types/react": "^17.0.7",
"@types/react-dom": "^17.0.5",
"@typescript-eslint/eslint-plugin": "^4.24.0",
"@typescript-eslint/parser": "^4.24.0",
"@typescript-eslint/eslint-plugin": "^4.25.0",
"@typescript-eslint/parser": "^4.25.0",
"autoprefixer": "^10.2.5",
"camelcase": "^6.2.0",
"cross-env": "^7.0.3",
"eslint": "^7.26.0",
"eslint": "^7.27.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-import": "2.23.2",
"eslint-plugin-import": "2.23.3",
"eslint-plugin-jest": "^24.3.6",
"eslint-plugin-jest-formatting": "^3.0.0",
"eslint-plugin-jsx-a11y": "^6.4.1",
Expand All @@ -69,7 +69,7 @@
"rimraf": "^3.0.2",
"shell-quote": "^1.7.2",
"symlink-dir": "^5.0.1",
"sync-directory": "^2.2.20",
"sync-directory": "^2.2.22",
"tailwindcss": "^2.1.2",
"ts-jest": "^26.5.6",
"typescript": "^4.2.4"
Expand All @@ -82,7 +82,7 @@
"@your-org/core-lib": "workspace:*",
"@your-org/ui-lib": "workspace:*",
"cross-env": "^7.0.3",
"next": "^10.2.2",
"next": "^10.2.3",
"next-secure-headers": "^2.2.0",
"next-seo": "^4.24.0",
"react": "^17.0.2",
Expand Down
2 changes: 1 addition & 1 deletion apps/web-app/next.config.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ const config = withBundleAnalyzer(
},

webpack: function (config, { defaultLoaders }) {
const resolvedBaseUrl = path.resolve(config.context, '../../');
// This extra config allows to use paths defined in tsconfig
// rather than next-transpile-modules.
// @link https://github.com/vercel/next.js/pull/13542
const resolvedBaseUrl = path.resolve(config.context, '../../');
config.module.rules = [
...config.module.rules,
{
Expand Down
24 changes: 12 additions & 12 deletions apps/web-app/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,30 +27,30 @@
"test": "run-s 'test:*'",
"test:unit": "jest --config jest.config.js --maxWorkers=50% --color $@",
"ci-test:unit": "jest --config jest.config.js --runInBand --color $@",
"typecheck": "tsc -p ./ --noEmit",
"typecheck": "tsc --project ./tsconfig.json --noEmit",
"lint": "eslint . --ext .ts,.tsx,.js,.jsx",
"fix:staged-files": "lint-staged --allow-empty",
"fix:all-files": "eslint . --ext .ts,.tsx,.js,.jsx --fix"
},
"devDependencies": {
"@emotion/babel-plugin": "^11.3.0",
"@next/bundle-analyzer": "^10.2.2",
"@tailwindcss/typography": "^0.4.0",
"@next/bundle-analyzer": "^10.2.3",
"@tailwindcss/typography": "^0.4.1",
"@testing-library/jest-dom": "^5.12.0",
"@testing-library/react": "^11.2.7",
"@testing-library/react-hooks": "^6.0.0",
"@types/jest": "^26.0.23",
"@types/node": "^15.6.0",
"@types/react": "^17.0.6",
"@types/node": "^15.6.1",
"@types/react": "^17.0.7",
"@types/react-dom": "^17.0.5",
"@typescript-eslint/eslint-plugin": "^4.24.0",
"@typescript-eslint/parser": "^4.24.0",
"@typescript-eslint/eslint-plugin": "^4.25.0",
"@typescript-eslint/parser": "^4.25.0",
"autoprefixer": "^10.2.5",
"camelcase": "^6.2.0",
"cross-env": "^7.0.3",
"eslint": "^7.26.0",
"eslint": "^7.27.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-import": "2.23.2",
"eslint-plugin-import": "2.23.3",
"eslint-plugin-jest": "^24.3.6",
"eslint-plugin-jest-formatting": "^3.0.0",
"eslint-plugin-jsx-a11y": "^6.4.1",
Expand All @@ -66,10 +66,10 @@
"prettier": "^2.3.0",
"prisma": "^2.23.0",
"rimraf": "^3.0.2",
"sass": "^1.33.0",
"sass": "^1.34.0",
"shell-quote": "^1.7.2",
"symlink-dir": "^5.0.1",
"sync-directory": "^2.2.20",
"sync-directory": "^2.2.22",
"tailwindcss": "^2.1.2",
"ts-jest": "^26.5.6",
"typescript": "^4.2.4"
Expand All @@ -83,7 +83,7 @@
"@your-org/core-lib": "workspace:*",
"@your-org/ui-lib": "workspace:*",
"cross-env": "^7.0.3",
"next": "^10.2.2",
"next": "^10.2.3",
"next-secure-headers": "^2.2.0",
"next-seo": "^4.24.0",
"react": "^17.0.2",
Expand Down
14 changes: 7 additions & 7 deletions packages/core-lib/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"dev": "microbundle watch",
"clean": "rimraf --no-glob ./dist",
"lint": "eslint . --ext .ts,.tsx,.js,.jsx",
"typecheck": "tsc -p ./ --noEmit",
"typecheck": "tsc --project ./tsconfig.json --noEmit",
"test": "run-s 'test:*'",
"test:unit": "echo \"No tests yet\"",
"fix:staged-files": "lint-staged --allow-empty",
Expand All @@ -33,15 +33,15 @@
"@testing-library/react": "^11.2.7",
"@testing-library/react-hooks": "^6.0.0",
"@types/jest": "^26.0.23",
"@types/node": "^15.6.0",
"@types/react": "^17.0.6",
"@types/node": "^15.6.1",
"@types/react": "^17.0.7",
"@types/react-dom": "^17.0.5",
"@typescript-eslint/eslint-plugin": "^4.24.0",
"@typescript-eslint/parser": "^4.24.0",
"@typescript-eslint/eslint-plugin": "^4.25.0",
"@typescript-eslint/parser": "^4.25.0",
"camelcase": "^6.2.0",
"eslint": "^7.26.0",
"eslint": "^7.27.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-import": "2.23.2",
"eslint-plugin-import": "2.23.3",
"eslint-plugin-jest": "^24.3.6",
"eslint-plugin-jest-formatting": "^3.0.0",
"eslint-plugin-jsx-a11y": "^6.4.1",
Expand Down
14 changes: 7 additions & 7 deletions packages/ui-lib/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"dev": "microbundle watch",
"clean": "rimraf --no-glob ./dist",
"lint": "eslint . --ext .ts,.tsx,.js,.jsx",
"typecheck": "tsc -p ./ --noEmit",
"typecheck": "tsc --project ./tsconfig.json --noEmit",
"test": "run-s 'test:*'",
"test:unit": "echo \"No tests yet\"",
"fix:staged-files": "lint-staged --allow-empty",
Expand All @@ -33,15 +33,15 @@
"@testing-library/react": "^11.2.7",
"@testing-library/react-hooks": "^6.0.0",
"@types/jest": "^26.0.23",
"@types/node": "^15.6.0",
"@types/react": "^17.0.6",
"@types/node": "^15.6.1",
"@types/react": "^17.0.7",
"@types/react-dom": "^17.0.5",
"@typescript-eslint/eslint-plugin": "^4.24.0",
"@typescript-eslint/parser": "^4.24.0",
"@typescript-eslint/eslint-plugin": "^4.25.0",
"@typescript-eslint/parser": "^4.25.0",
"camelcase": "^6.2.0",
"eslint": "^7.26.0",
"eslint": "^7.27.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-import": "2.23.2",
"eslint-plugin-import": "2.23.3",
"eslint-plugin-jest": "^24.3.6",
"eslint-plugin-jest-formatting": "^3.0.0",
"eslint-plugin-jsx-a11y": "^6.4.1",
Expand Down
Loading

2 comments on commit fafaef8

@vercel
Copy link

@vercel vercel bot commented on fafaef8 May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nextjs-monorepo-example-web-app – ./apps/web-app

nextjs-monorepo-example-web-app-git-main-belgattitude.vercel.app
nextjs-monorepo-example-web-app.vercel.app
nextjs-monorepo-example-web-app-belgattitude.vercel.app

@vercel
Copy link

@vercel vercel bot commented on fafaef8 May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nextjs-monorepo-example-blog-app – ./apps/blog-app

nextjs-monorepo-example-blog-app-belgattitude.vercel.app
nextjs-monorepo-example-blog-app-git-main-belgattitude.vercel.app
nextjs-monorepo-example-blog-app.vercel.app

Please sign in to comment.