Merge pull request #1341 from belgattitude/global-scripts-prefixes

Global scripts prefixes

.changeset/angry-lamps-kick.md

@@ -0,0 +1,6 @@
+---
+"blog-app": minor
+"web-app": minor
+---
+
+Add es-check to ensure produced build files passes ecmascript

.changeset/chatty-sloths-refuse.md

@@ -0,0 +1,11 @@
+---
+"blog-app": minor
+"remix-app": minor
+"vite-app": minor
+"web-app": minor
+"@your-org/core-lib": minor
+"@your-org/db-main-prisma": minor
+"@your-org/ui-lib": minor
+---
+
+Refactor scripts identifiers defined in package.json. Restrict usage of ':' in apps and packages

.changeset/config.json

@@ -1,13 +1,16 @@
 {
   "$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
-  "changelog": ["@changesets/changelog-github", { "repo": "belgattitude/nextjs-monorepo-example" }],
+  "changelog": [
+    "@changesets/changelog-github",
+    { "repo": "belgattitude/nextjs-monorepo-example" }
+  ],
   "commit": false,
   "linked": [],
-  "access": "private",
+  "access": "restricted",
   "baseBranch": "main",
   "updateInternalDependencies": "patch",
   "ignore": [],
   "___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
     "updateInternalDependents": "out-of-range"
   }
-}
+}

.changeset/gentle-rules-check.md

@@ -0,0 +1,6 @@
+---
+"blog-app": minor
+"remix-app": minor
+---
+
+Added stylint for css files

.changeset/short-news-leave.md

@@ -0,0 +1,5 @@
+---
+"blog-app": minor
+---
+
+Add size-limit checks for build files

.github/workflows/ci-blog-app.yml

@@ -90,11 +90,12 @@ jobs:
         working-directory: apps/blog-app
         run: |
           yarn lint --cache
+          yarn lint-styles
 
       - name: Unit tests
         working-directory: apps/blog-app
         run: |
-          yarn ci-test:unit
+          yarn test-unit --runInBand --color
 
       - name: Build blog-app
         working-directory: apps/blog-app
@@ -110,13 +111,23 @@ jobs:
           # Don't send telemetry for ci
           NEXT_TELEMETRY_DISABLED: 1
 
+      - name: Check bundle size
+        working-directory: apps/blog-app
+        run: |
+          yarn check-build-size
+
+      - name: Check ecmascript checks for build files
+        working-directory: apps/blog-app
+        run: |
+          yarn check-dist
+
       - name: Install Playwright
         run: npx playwright install --with-deps chromium webkit
 
       - name: E2E run blog-app playwright tests
         working-directory: apps/blog-app
         run: |
-          xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- yarn test:e2e
+          xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- yarn test-e2e
         env:
           E2E_WEBSERVER_MODE: BUILD_AND_START
           CI: 1

.github/workflows/ci-e2e-prisma.yml

@@ -6,17 +6,17 @@ on:
       - dev
       - main
     paths:
-      - "packages/db-main-prisma"
-      - ".github/workflows/**"
+      - 'packages/db-main-prisma'
+      - '.github/workflows/**'
 
   pull_request:
     types:
       - opened
       - synchronize
       - reopened
     paths:
-      - "packages/db-main-prisma"
-      - ".github/workflows/**"
+      - 'packages/db-main-prisma'
+      - '.github/workflows/**'
 
 jobs:
   e2e:
@@ -65,8 +65,6 @@ jobs:
       - name: E2E prisma
         working-directory: packages/db-main-prisma
         run: |
-          yarn test:e2e
+          yarn test-e2e
         env:
           E2E_PRISMA_DATABASE_URL: postgresql://postgres:postgres@localhost:5432/db-main-prisma-e2e?schema=public
-
-

.github/workflows/ci-e2e-web-app.yml

@@ -122,7 +122,7 @@ jobs:
       - name: E2E run web-app playwright tests
         working-directory: apps/web-app
         run: |
-          xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- yarn test:e2e
+          xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- yarn test-e2e
         env:
           E2E_WEBSERVER_MODE: BUILD_AND_START
           CI: 1

.github/workflows/ci-packages.yml

@@ -6,26 +6,26 @@ on:
       - dev
       - main
     paths:
-      - "packages/**"
-      - ".yarnrc.yml"
-      - ".prettier*.*"
-      - "*.base.json"
-      - "*.base.js"
-      - ".prettier*.*"
-      - ".github/workflows/**"
+      - 'packages/**'
+      - '.yarnrc.yml'
+      - '.prettier*.*'
+      - '*.base.json'
+      - '*.base.js'
+      - '.prettier*.*'
+      - '.github/workflows/**'
 
   pull_request:
     types:
       - opened
       - synchronize
       - reopened
     paths:
-      - "packages/**"
-      - ".yarnrc.yml"
-      - "*.base.json"
-      - "*.base.js"
-      - ".prettier*.*"
-      - ".github/workflows/**"
+      - 'packages/**'
+      - '.yarnrc.yml'
+      - '*.base.json'
+      - '*.base.js'
+      - '.prettier*.*'
+      - '.github/workflows/**'
 
 jobs:
   test:
@@ -85,21 +85,20 @@ jobs:
       - name: Linter
         run: |
           yarn workspaces foreach -tv --include '@your-org/*' --since=origin/main --recursive run lint --cache
+          yarn workspaces foreach -tv --include '@your-org/*' --since=origin/main --recursive run lint-styles
 
       # Test packages that have changed (--include & --since)
       - name: Unit tests changed packages
         run: |
-          yarn workspaces foreach -tv --include '@your-org/*' --since=origin/main --recursive run test:unit
+          yarn workspaces foreach -tv --include '@your-org/*' --since=origin/main --recursive run test-unit --runInBand --colors
       # to debug cache issues: ls ${{ github.workspace }}/.cache
-
       # Build packages that have changed (--include & --since), assuming that
       # apps build are done already. Otherwise --from & --since
       - name: Run build for changed packages
         run: |
-          yarn workspaces foreach -tv --include '@your-org/*' --since=origin/main run packages:build
+          yarn workspaces foreach -tv --include '@your-org/*' --since=origin/main run build
 
       # Test storybook build on packages that have changed (--include & --since)
       - name: Run storybook build for changed packages
         run: |
           yarn workspaces foreach -tv --exclude '*-app' --since=origin/main run build-storybook
-

.github/workflows/ci-remix-app.yml

@@ -6,16 +6,15 @@ on:
       - dev
       - main
     paths:
-      - "apps/remix-app/**"
-      - "packages/**"
-      - "package.json"
-      - "yarn.lock"
-      - ".yarnrc.yml"
-      - "*.base.json"
-      - "*.base.js"
-      - ".prettier*.*"
-      - ".github/workflows/**"
-
+      - 'apps/remix-app/**'
+      - 'packages/**'
+      - 'package.json'
+      - 'yarn.lock'
+      - '.yarnrc.yml'
+      - '*.base.json'
+      - '*.base.js'
+      - '.prettier*.*'
+      - '.github/workflows/**'
 
   pull_request:
     types:
@@ -26,15 +25,15 @@ on:
     #   Only consider those files/paths to trigger the github action
     #   to prevent unnecessary builds.
     paths:
-      - "apps/remix-app/**"
-      - "packages/**"
-      - "package.json"
-      - "yarn.lock"
-      - ".yarnrc.yml"
-      - "*.base.json"
-      - "*.base.js"
-      - ".prettier*.*"
-      - ".github/workflows/**"
+      - 'apps/remix-app/**'
+      - 'packages/**'
+      - 'package.json'
+      - 'yarn.lock'
+      - '.yarnrc.yml'
+      - '*.base.json'
+      - '*.base.js'
+      - '.prettier*.*'
+      - '.github/workflows/**'
 
 jobs:
   test:
@@ -78,14 +77,14 @@ jobs:
         working-directory: apps/remix-app
         run: |
           yarn lint --cache
+          yarn lint-styles
 
       - name: Unit tests
         working-directory: apps/remix-app
         run: |
-          yarn ci-test:unit
+          yarn test-unit --runInBand --color
 
       - name: Build remix-app
         working-directory: apps/remix-app
         run: |
           yarn build
-

.github/workflows/ci-vite-app.yml

@@ -6,31 +6,31 @@ on:
       - dev
       - main
     paths:
-      - "apps/vite-app/**"
-      - "packages/**"
-      - "package.json"
-      - "yarn.lock"
-      - ".yarnrc.yml"
-      - "*.base.json"
-      - "*.base.js"
-      - ".prettier*.*"
-      - ".github/workflows/**"
+      - 'apps/vite-app/**'
+      - 'packages/**'
+      - 'package.json'
+      - 'yarn.lock'
+      - '.yarnrc.yml'
+      - '*.base.json'
+      - '*.base.js'
+      - '.prettier*.*'
+      - '.github/workflows/**'
 
   pull_request:
     types:
       - opened
       - synchronize
       - reopened
     paths:
-      - "apps/vite-app/**"
-      - "packages/**"
-      - "package.json"
-      - "yarn.lock"
-      - ".yarnrc.yml"
-      - "*.base.json"
-      - "*.base.js"
-      - ".prettier*.*"
-      - ".github/workflows/**"
+      - 'apps/vite-app/**'
+      - 'packages/**'
+      - 'package.json'
+      - 'yarn.lock'
+      - '.yarnrc.yml'
+      - '*.base.json'
+      - '*.base.js'
+      - '.prettier*.*'
+      - '.github/workflows/**'
 
 jobs:
   test:
@@ -78,12 +78,9 @@ jobs:
       - name: Unit tests
         working-directory: apps/vite-app
         run: |
-          yarn ci-test:unit
+          yarn test-unit --runInBand --color
 
       - name: Build vite-app
         working-directory: apps/vite-app
         run: |
           yarn build
-
-
-

.github/workflows/ci-web-app.yml

@@ -97,7 +97,7 @@ jobs:
       - name: Unit tests
         working-directory: apps/web-app
         run: |
-          yarn ci-test:unit
+          yarn test-unit --runInBand --color
 
       - name: Build web-app
         working-directory: apps/web-app
@@ -120,4 +120,9 @@ jobs:
       - name: Check bundle size
         working-directory: apps/web-app
         run: |
-          yarn bundle:check-size
+          yarn check-build-size
+
+      - name: Check ecmascript checks for build files
+        working-directory: apps/web-app
+        run: |
+          yarn check-dist

.husky/pre-commit

@@ -1,4 +1,4 @@
 #!/bin/sh
 . "$(dirname "$0")/_/husky.sh"
 
-yarn g:fix-staged-files --debug
+yarn g:lint-staged-files --debug