Skip to content

Commit

Permalink
Merge pull request #181 from belgattitude/fix-peer-deps-meta
Browse files Browse the repository at this point in the history
Fix peer deps meta
  • Loading branch information
belgattitude authored Jul 20, 2021
2 parents 49002f0 + c5173ea commit 73b8a83
Show file tree
Hide file tree
Showing 6 changed files with 38 additions and 8 deletions.
6 changes: 6 additions & 0 deletions .changeset/forty-masks-shave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'blog-app': patch
'web-app': patch
---

Fix possible issues with peerDeps
5 changes: 5 additions & 0 deletions .changeset/thirty-stingrays-double.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@your-org/core-lib': minor
---

Allow peerDependencies on react to be optional
1 change: 1 addition & 0 deletions apps/blog-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@
"typescript": "4.3.5"
},
"dependencies": {
"@babel/core": "7.14.6",
"@emotion/react": "11.4.0",
"@emotion/styled": "11.3.0",
"@headlessui/react": "1.3.0",
Expand Down
2 changes: 2 additions & 0 deletions apps/web-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@
"typescript": "4.3.5"
},
"dependencies": {
"@babel/core": "7.14.6",
"@emotion/react": "11.4.0",
"@emotion/styled": "11.3.0",
"@headlessui/react": "1.3.0",
Expand All @@ -107,6 +108,7 @@
"axios": "0.21.1",
"cors": "2.8.5",
"cross-env": "7.0.3",
"i18next": "20.3.3",
"ky": "0.28.5",
"next": "11.0.1",
"next-auth": "3.27.3",
Expand Down
8 changes: 8 additions & 0 deletions packages/core-lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,13 @@
"peerDependencies": {
"react": "^16.14.0 || ^17.0.2",
"react-dom": "^16.14.0 || ^17.0.2"
},
"peerDependenciesMeta": {
"react": {
"optional": true
},
"react-dom": {
"optional": true
}
}
}
24 changes: 16 additions & 8 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3460,6 +3460,11 @@ __metadata:
peerDependencies:
react: ^16.14.0 || ^17.0.2
react-dom: ^16.14.0 || ^17.0.2
peerDependenciesMeta:
react:
optional: true
react-dom:
optional: true
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -4335,6 +4340,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "blog-app@workspace:apps/blog-app"
dependencies:
"@babel/core": 7.14.6
"@emotion/babel-plugin": 11.3.0
"@emotion/react": 11.4.0
"@emotion/styled": 11.3.0
Expand Down Expand Up @@ -8106,21 +8112,21 @@ __metadata:
languageName: node
linkType: hard

"i18next@npm:^19.7.0":
version: 19.9.2
resolution: "i18next@npm:19.9.2"
"i18next@npm:20.3.3, i18next@npm:^20.1.0":
version: 20.3.3
resolution: "i18next@npm:20.3.3"
dependencies:
"@babel/runtime": ^7.12.0
checksum: a24207707eacb28488975f8921d843bc35b86f2a48504cb82eaf620e1aacddbda8d53a4dc600543a708ba49bc45e61072a753f250e89fad2c1932259190ef81a
checksum: 906fae951a0932403708a47c919a5e1d8b7e2300a254c6e6bb82923474eb0a7e3a66fc7fa03d7ebbc8a04f50a5a272be44d797a54ceb2cddbca6b639ca7e5a8e
languageName: node
linkType: hard

"i18next@npm:^20.1.0":
version: 20.3.2
resolution: "i18next@npm:20.3.2"
"i18next@npm:^19.7.0":
version: 19.9.2
resolution: "i18next@npm:19.9.2"
dependencies:
"@babel/runtime": ^7.12.0
checksum: 71867418c1d3e477b453daa0696999fe80a4b2c6d37b27fff073645a5e06b36b6adbf02bff738e288e523add10bb6b16dd72e0c13f3d6a2a3733836dcdbcd5ec
checksum: a24207707eacb28488975f8921d843bc35b86f2a48504cb82eaf620e1aacddbda8d53a4dc600543a708ba49bc45e61072a753f250e89fad2c1932259190ef81a
languageName: node
linkType: hard

Expand Down Expand Up @@ -16008,6 +16014,7 @@ resolve@^2.0.0-next.3:
version: 0.0.0-use.local
resolution: "web-app@workspace:apps/web-app"
dependencies:
"@babel/core": 7.14.6
"@emotion/babel-plugin": 11.3.0
"@emotion/react": 11.4.0
"@emotion/styled": 11.3.0
Expand Down Expand Up @@ -16048,6 +16055,7 @@ resolve@^2.0.0-next.3:
eslint-plugin-react: 7.24.0
eslint-plugin-react-hooks: 4.2.0
eslint-plugin-testing-library: 4.9.1
i18next: 20.3.3
jest: 27.0.6
jest-css-modules-transform: 4.3.0
ky: 0.28.5
Expand Down

2 comments on commit 73b8a83

@vercel
Copy link

@vercel vercel bot commented on 73b8a83 Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vercel
Copy link

@vercel vercel bot commented on 73b8a83 Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.