Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated from latest linter recommendations #1418

Merged
merged 30 commits into from
Sep 9, 2024
Merged

Updated from latest linter recommendations #1418

merged 30 commits into from
Sep 9, 2024

Conversation

belgattitude
Copy link
Owner

No description provided.

Copy link

changeset-bot bot commented Sep 5, 2024

🦋 Changeset detected

Latest commit: ee399b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@httpx/dsn-parser Patch
@httpx/assert Minor
@httpx/plain-object Patch
@httpx/exception Patch
@httpx/memo-intl Patch
@httpx/json-api Patch
@httpx/treeu Patch
@examples/nextjs-app Patch
prisma-exception Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Sep 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ee399b2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

socket-security bot commented Sep 5, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@arethetypeswrong/[email protected] Transitive: environment, filesystem, shell +13 6.36 MB andrewbranch
npm/@size-limit/[email protected] None 0 3.43 kB ai
npm/@size-limit/[email protected] environment Transitive: eval, filesystem +28 4.86 MB ai
npm/@size-limit/[email protected] None +1 18.8 kB ai
npm/@types/[email protected] None 0 37.8 kB types
npm/@vitejs/[email protected] filesystem, unsafe Transitive: environment, shell +12 443 MB vitebot
npm/@vitest/[email protected] None +1 91.5 kB vitestbot
npm/@vitest/[email protected] Transitive: environment, filesystem +18 3.2 MB vitestbot
npm/@vitest/[email protected] Transitive: environment +7 2.01 MB vitestbot
npm/[email protected] None +1 427 kB marcofugaro
npm/[email protected] filesystem Transitive: environment, shell +2 732 kB yowainwright
npm/[email protected] None +24 241 MB esbuild, evanw
npm/[email protected] unsafe Transitive: environment, filesystem, shell +38 7.49 MB vercel-release-bot
npm/[email protected] None 0 217 kB francoismassart
npm/[email protected] network, shell, unsafe +2 9.39 MB davidortner
npm/[email protected] None 0 157 kB sindresorhus
npm/[email protected] environment, filesystem, network, shell, unsafe +19 1.2 GB vercel-release-bot
npm/[email protected] Transitive: environment, eval +23 5.15 MB quietshu
npm/[email protected] environment Transitive: eval, filesystem, network, shell, unsafe +309 158 MB quietshu
npm/[email protected] environment, unsafe Transitive: eval, filesystem +17 1.84 MB matteo.collina
npm/[email protected] None +4 260 kB romainmenke
npm/[email protected] environment, filesystem +2 364 kB ai
npm/[email protected] None 0 882 kB cagatay.civici
npm/[email protected] Transitive: environment +3 59.4 MB tprkkc
npm/[email protected] environment +1 4.61 MB react-bot
npm/[email protected] environment, filesystem, network +7 93.8 kB lukeed
npm/[email protected] filesystem +3 65.4 kB lukeed
npm/[email protected] None +2 147 kB skn0tt
npm/[email protected] None 0 709 kB dcas
npm/[email protected] environment, filesystem Transitive: network, shell, unsafe +61 10.6 MB adamwathan
npm/[email protected] filesystem +21 541 kB pd4d10
npm/[email protected] filesystem +2 142 kB aleclarson
npm/[email protected] environment, eval, filesystem, network, shell, unsafe +32 235 MB vitebot
npm/[email protected] environment, eval Transitive: filesystem, shell, unsafe +27 6.08 MB vitestbot
npm/[email protected] Transitive: environment, eval, filesystem, shell +49 14.1 MB evilebottnawi, jhnns, sokra, ...1 more

🚮 Removed packages: npm/[email protected])

View full report↗︎

Copy link

codspeed-hq bot commented Sep 5, 2024

CodSpeed Performance Report

Merging #1418 will degrade performances by 53.51%

Comparing linter-update (ee399b2) with main (95e5490)

Summary

⚡ 1 improvements
❌ 3 regressions
✅ 9 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main linter-update Change
FlatTreeWsMapper.toTreeNodesOrThrow 63.5 ms 86.6 ms -26.7%
DfsTreeSearch.findOne(id_1000) over 10_000 782.2 µs 998.5 µs -21.66%
DfsTreeSearch.findOne(id_5000) over 10_000 11.3 ms 5.2 ms ×2.2
DfsTreeSearch.findOne(id_NotExists) over 10_000 7.2 ms 15.6 ms -53.51%

# Conflicts:
#	integrations/prisma-exception/package.json
#	packages/assert/package.json
#	packages/dsn-parser/package.json
#	packages/exception/package.json
#	packages/json-api/package.json
#	packages/memo-intl/package.json
#	packages/plain-object/package.json
#	packages/treeu/package.json
#	yarn.lock
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 93.35%. Comparing base (95e5490) to head (ee399b2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/assert/src/messages/getTypeInfo.ts 33.33% 0 Missing and 2 partials ⚠️
packages/json-api/src/json-api-error.factory.ts 0.00% 2 Missing ⚠️
packages/treeu/src/tree-guards.ts 0.00% 2 Missing ⚠️
packages/assert/src/uuid.helpers.ts 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1418      +/-   ##
==========================================
+ Coverage   93.30%   93.35%   +0.05%     
==========================================
  Files         131      131              
  Lines        1270     1265       -5     
  Branches      270      268       -2     
==========================================
- Hits         1185     1181       -4     
+ Misses         76       73       -3     
- Partials        9       11       +2     
Flag Coverage Δ
httpx-assert-unit 93.35% <73.07%> (+0.05%) ⬆️
httpx-dsn-parser-unit 93.35% <73.07%> (+0.05%) ⬆️
httpx-exception-unit 93.35% <73.07%> (+0.05%) ⬆️
httpx-json-api-unit 93.35% <73.07%> (+0.05%) ⬆️
httpx-memo-intl-unit 93.35% <73.07%> (+0.05%) ⬆️
httpx-plain-object-unit 93.35% <73.07%> (+0.05%) ⬆️
httpx-treeu-unit 93.35% <73.07%> (+0.05%) ⬆️
Files with missing lines Coverage Δ
packages/assert/src/__tests__/object.types.test.ts 92.98% <ø> (-0.24%) ⬇️
...ackages/assert/src/__tests__/string.assert.test.ts 100.00% <ø> (ø)
packages/assert/src/__tests__/uuid.utils.test.ts 100.00% <ø> (ø)
packages/assert/src/messages/errorMessages.ts 100.00% <100.00%> (ø)
packages/assert/src/string.asserts.ts 95.00% <100.00%> (-0.24%) ⬇️
packages/assert/src/utils/createAssertException.ts 100.00% <100.00%> (ø)
packages/assert/src/uuid.asserts.ts 100.00% <ø> (ø)
packages/assert/src/uuid.utils.ts 100.00% <ø> (ø)
packages/dsn-parser/src/dsn-parser.type.ts 100.00% <ø> (ø)
packages/dsn-parser/src/dsn-parser.util.ts 100.00% <100.00%> (ø)
... and 10 more

@belgattitude belgattitude changed the title Linter update Updated from latest linter recommendations Sep 9, 2024
@belgattitude belgattitude merged commit 366520a into main Sep 9, 2024
19 checks passed
@belgattitude belgattitude deleted the linter-update branch September 9, 2024 12:58
@belgattitude belgattitude mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant