Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas does not render in ScrollContainer in macOS #580

Closed

Conversation

polarmutex
Copy link

On macOS, the canvas widget was not rendering in the scroll container.

The widgets need to be added to the sub view for the drawRect function to be called on the canvas. The changes I have so far allow the canvas to be rendered, however if you have draw commands outside of the viewable window, no scroll bar appears.

I believe this is the case since the canvas widget never reports its viewable bounds correctly to toga. It just reports the bounds of the viewable container, so the scroll container thinks it does not need a scroll bar. I am new to core graphics and have not found a way to get those bounds numbers. Any help would be appreciated

Fixes #579

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@phildini
Copy link
Member

Hey! Are still interested in merging this? Would you be willing to add some tests for this?

@freakboy3742
Copy link
Member

To clarify - in this case, tests is probably more along the lines of "a demo app that we can use to provide the changes work as advertised. There might be some useful crossover with #792.

@freakboy3742
Copy link
Member

Closing due to lack of activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canvas does not render in ScrollContainer
3 participants