Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing dialog clashing on iOS bug (#2039) #2041

Merged
merged 2 commits into from
Jul 22, 2023
Merged

Fixing dialog clashing on iOS bug (#2039) #2041

merged 2 commits into from
Jul 22, 2023

Conversation

Cheukting
Copy link
Contributor

@Cheukting Cheukting commented Jul 22, 2023 •
edited
Loading

in /iOS/src/toga_iOS/dialogs.py

-        interface.window._impl.controller.presentViewController(
+        interface.window._impl.native.rootViewController.presentViewController(

Fixing a bug introduced in #1969 that clashes the dialog display on iOS

fix #2039

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

freakboy3742
freakboy3742 approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for the contribution!

@freakboy3742 freakboy3742 merged commit 930f4e3 into beeware:main Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when displaying InfoDialog on iOS
2 participants
@Cheukting @freakboy3742