Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test app #1687
Test app #1687
Changes from 3 commits
d8e33fd
5ce684a
90f1873
71d7487
0481126
06dc8ac
296b424
fcd6b9a
0d65ecf
da146a0
ad710a9
d50e9fd
0593b52
2c97ac3
87287de
8beba38
c3cf437
94594ab
8a62cec
9e6c692
5d2dd6c
dd8739c
1ddcb53
20130d1
5d9982a
018fb41
3ae99ae
a9580ce
426ae43
89f99b8
30f4c82
347b112
9d6c88c
30295c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took me a while to work out what was going on here; 2 questions coming from this:
simple_layout(widget)
which puts the test widget into a simple box layout?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if they call any Toga APIs, because making them async is what causes them to run on the main thread.
I'm not quite sure what you mean, but I'll adjust the fixture names and dependencies so it's clearer what each one is actually doing.