Add mechamism for explicit requires package repository references
#2057
Conversation
| with self.input.wait_bar("Writing requirements file..."): | ||
| with requirements_path.open("w", encoding="utf-8") as f: | ||
| if requires: | ||
| if requires or extra_pip_args: |
There was a problem hiding this comment.
My inclination is that this is the right idea, not taken far enough. If we're generating a new file, we should always be writing the timestamp - worst case, we end up with a file that only contains the timestamp, rather than a literally empty file.
There was a problem hiding this comment.
Totally, makes sense to do away with the check altogether.
Also noting that I'd originally moved the check to the function root and done an early return when nothing would be written, but if requirements are being removed, it still needs to write the file to reflect requirements changed. Removing the conditional on the timestamp write makes that aspect a bit clearer as well (maybe with a small comment to help explain).
|
Closing this based on the discussion in the linked issue, and in particular this comment from Russell confirming the other approach. I'll work on a changeset for that this week and hope to have a PR up in the next couple of days 🙂 |
Part of #1270.
Does not close out #1270 because @freakboy3742 also requested adding support for pip's
--find-links. I chose to leave that out of this PR because this PR already has enough edge cases to consider (see the issue for discussion about them), and supporting--find-linksrequires thinking about how to generically describe it.While this PR is feature complete for
--index-urland--extra-index-url, which were the original concerns of the linked issue, I'm leaving it as a draft in order to propose a very different approach, which might simplify description of the feature, and better anticipate future changes like support/hooks for different package installation backends.PR Checklist: