Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PPB #1834

Merged
merged 5 commits into from
May 22, 2024
Merged

Remove PPB #1834

merged 5 commits into from
May 22, 2024

Conversation

AstraLuma
Copy link
Contributor

Per current Briefcase best practices, migrating the PPB integration to PPB itself.

Companion: ppb/pursuedpybear#722

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@AstraLuma AstraLuma mentioned this pull request May 22, 2024
Open
@AstraLuma AstraLuma mentioned this pull request May 22, 2024
Open
freakboy3742
freakboy3742 requested changes May 22, 2024
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good; it's now failing because we still have PPB checks in the CI configuration.

AstraLuma added a commit to AstraLuma/briefcase-template that referenced this pull request May 22, 2024
@AstraLuma
Remove PPB from CI
ce84407 
Re beeware/briefcase#1834
This was referenced May 22, 2024
Merged
Merged
freakboy3742
freakboy3742 approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for show of support in Briefcase that you're willing to take the leap on externally hosting the plugin!

@freakboy3742 freakboy3742 merged commit 7552b9e into beeware:main May 22, 2024
43 checks passed
@AstraLuma AstraLuma mentioned this pull request May 22, 2024
Merged
4 tasks
@AstraLuma AstraLuma deleted the rm-ppb branch May 22, 2024 17:40
This was referenced May 22, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AstraLuma @freakboy3742