Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall back to system allocated port if port in use for web server #1561

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Fall back to system allocated port if port in use for web server #1561

merged 1 commit into from
Dec 4, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Dec 4, 2023 •
edited
Loading

Changes

  • Instead of just erroring if port 8080 is already in use, warn the user and use a system-allocated port

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review December 4, 2023 15:15
freakboy3742
freakboy3742 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit 003715b into beeware:main Dec 4, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmartin16 @freakboy3742