Remove Windows Store Python testing from CI #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The underlying API to download this Python is no longer available to GitHub runners
rmartin16
force-pushed
the
remove-winstore-ci-tests
branch
from
4798990
to
5ce8ed7
Compare
4 tasks
freakboy3742
requested changes
Nov 14, 2023
.github/workflows/ci.yml
Outdated
| @@ -103,7 +92,7 @@ jobs: | |||
| id: coverage | |||
| if: always() && contains('success,failure', steps.test.outcome) | |||
| # coverage reporting must use the same Python version used to produce coverage | |||
| run: tox -qe coverage$(echo '${{ matrix.python-version }}' | tr -dc '0-9') | |||
| run: tox -qe coverage$(tr -d "." <<< "${{ matrix.python-version }}") | |||
There was a problem hiding this comment.
Won't 3.13-dev cause a problem here?
There was a problem hiding this comment.
Yes....but that's a problem for whoever adds 3.13 support ;)
I'll restore the slightly more complicated tr
freakboy3742
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist: