Use installer args file for pip options #53
Merged
+38
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mhsmith
reviewed
Nov 18, 2024
Co-authored-by: Malcolm Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to beeware/briefcase#1270
Follow up to #52
Based on the discussion in this PR to address the linked issue in Briefcase: beeware/briefcase#2059 (comment). This PR depends on changes in
A desire for a generic interface to define pip install arguments was expressed. Using Python to generate the
pip installinvocation and executing it withexecvensures that the method for reading thepip-options.txtfile as a newline delimited list of command arguments is shell agnostic (e.g., does not rely on bash being the shell in order to use its arrays).Not entirely sure if this is what y'all had in mind @freakboy3742 and @mhsmith but let me know your thoughts.
PR Checklist: