Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Windows Store Python testing from CI #66

Merged
merged 1 commit into from
Nov 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 0 additions & 88 deletions .github/actions/install-win-store-python/action.yml

This file was deleted.

11 changes: 0 additions & 11 deletions .github/workflows/app-build-verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ on:
description: "Python version to use; defaults to latest Python release."
default: "3.X"
type: string
python-source:
description: "Where to install python from; i.e. github or winstore."
default: "github"
type: string
runner-os:
description: "The OS to use to build the App; must be a fully qualified GitHub runner OS, e.g. ubuntu-latest."
required: true
Expand Down Expand Up @@ -107,17 +103,10 @@ jobs:
echo "python-version=$(python3 -c 'import sys; print(f"{sys.version_info.major}.{sys.version_info.minor}")')" >> ${GITHUB_OUTPUT}

- name: Set up Python
if: inputs.python-source == 'github'
uses: actions/[email protected]
with:
python-version: ${{ inputs.python-version }}

- name: Install Windows Store Python
if: inputs.python-source == 'winstore'
uses: ./beeware-.github/.github/actions/install-win-store-python
with:
python-version: ${{ inputs.python-version }}

- name: Get packages
# Briefcase will build and package itself in a previous step in its CI.
if: endsWith(inputs.repository, 'briefcase')
Expand Down
34 changes: 0 additions & 34 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,38 +139,6 @@ jobs:
exit 1
fi

test-install-win-store-python:
name: Test Win Store Python Installation
needs: pre-commit
runs-on: windows-latest
timeout-minutes: 30
strategy:
matrix:
python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12" ]
steps:
- uses: actions/[email protected]

- name: Install Windows Store Python
uses: ./.github/actions/install-win-store-python
with:
python-version: ${{ matrix.python-version }}

- name: Test Windows Store Python Install
shell: powershell
run: |
$PythonExeSubDir = "\Microsoft\WindowsApps\PythonSoftwareFoundation.Python.${{ matrix.python-version }}_qbz5n2kfra8p0\python.exe"
$ExpectedPythonPath = Join-Path "$env:LOCALAPPDATA" "$PythonExeSubDir"
if ( "$((Get-Command python).Path)" -ne "$ExpectedPythonPath" ) {
echo "Python is at $((Get-Command python).Path)"
echo "Python was expected at $ExpectedPythonPath"
exit 1
}
if ( "$(python -V)" -cnotlike "Python ${{ matrix.python-version }}*" ) {
echo "Found $(python -V)"
echo "Expected Python ${{ matrix.python-version }}"
exit 1
}

test-pre-commit-run:
name: Test Pre-commit
needs: pre-commit
Expand Down Expand Up @@ -355,7 +323,6 @@ jobs:
uses: ./.github/workflows/app-build-verify.yml
with:
python-version: "3.11"
python-source: ${{ matrix.python-source }}
repository: beeware/briefcase-windows-${{ matrix.format }}-template
runner-os: windows-latest
target-platform: windows
Expand All @@ -366,4 +333,3 @@ jobs:
matrix:
format: [ "app", "VisualStudio" ]
framework: [ "toga", "ppb" ]
python-source: [ "github", "winstore" ]
Loading