Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote bash variables with double quotes #27

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Quote bash variables with double quotes #27

merged 1 commit into from
Apr 2, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Apr 2, 2023 •
edited
Loading

Runs of the pre-commit-update workflow failed because I wrapped the bash variable for the filename in single quotes; so all the changenotes were titled ${FILENAME}....let's use double quotes instead.

Example: beeware/briefcase#1162

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review April 2, 2023 22:27
freakboy3742
freakboy3742 approved these changes Apr 2, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@freakboy3742 freakboy3742 merged commit 6580e87 into beeware:main Apr 2, 2023
@rmartin16 rmartin16 deleted the pre-commit-update-quotes branch April 2, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmartin16 @freakboy3742