Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetchart: Use the right field to obtain Spotify album id #4804

Merged
merged 3 commits into from
May 30, 2023
Merged

Fetchart: Use the right field to obtain Spotify album id #4804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f1add8
Change to spotify_album_id
arsaboo May 26, 2023
7a9d8f9
added error handling
arsaboo May 26, 2023
c0bae4e
Update changelog.rst
arsaboo May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion beetsplug/fetchart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,11 @@ def available(cls, log, config):
return HAS_BEAUTIFUL_SOUP

def get(self, album, plugin, paths):
url = self.SPOTIFY_ALBUM_URL + album.mb_albumid
try:
url = self.SPOTIFY_ALBUM_URL + album.items().get().spotify_album_id
except AttributeError:
self._log.debug('Fetchart: no Spotify album ID found')
return
try:
response = requests.get(url)
response.raise_for_status()
Expand Down
2 changes: 2 additions & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ for Python 3.6).

New features:

* Fetchart: Use the right field (`spotify_album_id`) to obtain the Spotify album id
:bug:`4803`
* Prevent reimporting album if it is permanently removed from Spotify
:bug:`4800`
* Added option use `cover_art_arl` as an album art source in the `fetchart` plugin.
Expand Down