-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spotify as a fetchart source #4771
Conversation
Looks reasonable at a first glance 🎉 (Without checking anything Spotify-specific.) One small thing: We list |
Thanks for the review @wisp3rwind. I have updated the code to make |
Looking good! Would you mind rebasing on (or merging) master in order to get #4772 for a proper CI run? |
Thanks @wisp3rwind for that fix...all green now ✅ |
Great! I didn't check whether the Spotify "API" usage is correct, but since this is well-contained and otherwise the code looks good, I'm just going ahead and merge. |
Added
spotify
as a fetchart source.Let me know if this approach looks fine.
To Do
docs/
to describe it.)docs/changelog.rst
near the top of the document.)