Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NullPaddedInt for all r128_album_gain fields. #3261

Merged
merged 1 commit into from
May 9, 2019
Merged

Use NullPaddedInt for all r128_album_gain fields. #3261

merged 1 commit into from
May 9, 2019

Conversation

djl
Copy link
Member

@djl djl commented May 9, 2019

See my comment on #3049.

@djl djl mentioned this pull request May 9, 2019
Closed
@sampsyo
Copy link
Member

sampsyo commented May 9, 2019

This looks like exactly the thing to do. #2813 introduced NullPaddedInt for those fields, and it seems to have left out the album version.

sampsyo
sampsyo approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preemptively approved, if it in fact solves the problem for those who were seeing! Feel free to merge it with a changelog entry.

@djl djl merged commit 9ddf028 into master May 9, 2019
@djl
Copy link
Member Author

djl commented May 9, 2019

I intentionally left out the changelog entry because the NullPaddedInt changes haven't yet made it into a release. This is just a small bugfix and should be covered by the that change's changelog entry (right?).

@sampsyo
Copy link
Member

sampsyo commented May 9, 2019

Yep, sounds good.

@GuilhermeHideki GuilhermeHideki deleted the nullpadeverything branch February 8, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampsyo sampsyo sampsyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djl @sampsyo