bpd: support short form of list command for albums #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampsyo
approved these changes
Apr 13, 2019
Some clients list the albums belonging to an artist by issuing the command `list album <ARTIST NAME>`. This change inserts the tag `artist` before the artist name so that this succeeds. Fixes #3007
|
Just to note though that the MPD developer has indicated that the MPD protocol docs are not complete and that the software should be used as a reference to answer any questions. I don't think this is non-standard behaviour, just an undocumented part of the protocol that clients were already relying on. The MPD query syntax was overhauled in 0.21, so I think this syntax is only still supported by MPD for backwards-compatibility. It might even be that the clients stop issuing these type of queries once we start claiming to be a more modern version of MPD. |
20 tasks
|
Got it; that makes sense! In that case, I suppose it's not shocking that the real-world usage would differ from the docs. Thanks for clarifying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clients list the albums belonging to an artist by issuing the command
list album <ARTIST NAME>. This change inserts the tagartistbefore the artist name so that this succeeds. Fixes #3007.I confirmed the behaviour with the current MPD. It gave a rather helpful error message
ACK [2@0] {list} should be "Album" for 3 argumentsthat shows that the shorter version is only for getting the albums of an artist.A small unrelated change is to address a minor issue where if clients listed all album artists the first result would be blank (due to not all items in beets' database having album artist tags). We just skip any blank responses for the specific case of listing all unique values of a tag.