Fix kodiupdate URL and add better error reporting #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@natezb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Pauligrinder to be a potential reviewer. |
|
Thank you for noticing and fixing this! The URL change seems harmless enough, even for other setups where the old URL happened to work. And the new error handling is a very good idea. Would you mind adding a changelog entry? Then this will be ready to merge. |
|
Fantastic! ✨ Thank you again. |
sampsyo
added a commit
that referenced
this pull request
Aug 22, 2017
Fix kodiupdate URL and add better error reporting
|
Man, that was quick! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important aspect of this change is to correct the Kodi URL. The current URL, which has a trailing slash, produces a 404 error on my system (Kodi v17.1 on ArchLinux).
The existing error handling/logging missed this, so I added checks of the HTTP status code and the JSON response data for more detailed information.