#2347: First hack of ignoring already tagged items #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kraymer
reviewed
Dec 27, 2016
|
|
||
| if not force: | ||
| mood_str = item.get('mood_acoustic', u'') | ||
| if len(mood_str) != 0: |
Kraymer
reviewed
Dec 27, 2016
| @@ -118,7 +119,13 @@ def commands(self): | |||
|
|
|||
| def func(lib, opts, args): | |||
| items = lib.items(ui.decargs(args)) | |||
| self._fetch_info(items, ui.should_write()) | |||
| self._fetch_info(items, ui.should_write(),opts.force_refetch or self.config['force']) | |||
There was a problem hiding this comment.
,opts.force_refetch => , opts.force_refetch
sampsyo
requested changes
Dec 27, 2016
There was a problem hiding this comment.
This looks fantastic; thank you! @Kraymer has a couple of small suggestions, and I found one addition that could be useful here. And would you mind adding just a sentence or two about the new option to the plugin's documentation page (docs/plugins/acousticbrainz.rst)?
| @@ -118,7 +119,13 @@ def commands(self): | |||
|
|
|||
There was a problem hiding this comment.
I think we might need something like this to make the command-line flag work:
cmd.parser.add_option(
u'-f', u'--force', dest='force_refetch',
action='store_true', default=False,
help=u're-download data if present',
)
sampsyo
added a commit
that referenced
this pull request
Dec 28, 2016
#2347: First hack of ignoring already tagged items
sampsyo
added a commit
that referenced
this pull request
Dec 28, 2016
sampsyo
added a commit
that referenced
this pull request
Dec 28, 2016
sampsyo
added a commit
that referenced
this pull request
Dec 28, 2016
|
Looks perfect! Thank you! ✨ 🚀 🤖 I've merged this for inclusion in the next release. |
sampsyo
added a commit
that referenced
this pull request
Dec 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the speed of fetching acousticbrainz data. Ignore already existing data.